Add packaging support for 16.04 (and remove gunicorn) #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @3XX0 |
|
Just did a sanity check and it worked without issue. |
lukeyeager
force-pushed
the
systemd
branch
3 times, most recently
from
e533941
to
49ba398
Compare
|
@gheinrich any concerns with this? |
gheinrich
reviewed
Sep 30, 2016
| -d, --debug Run the application in debug mode (reloads when the | ||
| source changes and gives more detailed error messages) | ||
| --version Print the version number and exit | ||
| python -m digits |
There was a problem hiding this comment.
so "[Optional] Enable support for plug-ins" is not optional anymore?
There was a problem hiding this comment.
while you're at it, why not add a console_scripts entry point? So we can start DIGITS by just typing digits [options] from anywhere?
There was a problem hiding this comment.
- Technically, it is still optional. You can run
python -m digitswithoutpip install digitsas long as you're in$DIGITS_ROOT. - I was having problems with that, but I think it's probably fixed by https://github.com/NVIDIA/DIGITS/pull/1124/files. Let me check again...
There was a problem hiding this comment.
Actually, I think I'll leave digits-devserver in there for now and keep telling people to use it. Next step can be:
- PyPI support
- Console entry point (it does work now)
lukeyeager
force-pushed
the
systemd
branch
2 times, most recently
from
b388284
to
b50f7ff
Compare
Gunicorn complicates packaging (especially with Systemd) We're not getting any of the advantages that usually come with gunicorn because our server is single-process and single-thread We can handle the auto-restart with the init system service
Various other small packaging changes/improvements Rename nginx to NGINX: https://forum.nginx.org/read.php?2,255874,255879
This was referenced Oct 31, 2016
Closed
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
Add packaging support for 16.04 (and remove gunicorn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1113
As explained in the commit messages, gunicorn isn't doing any good for us at present.
Since #1121,
digits-devserverisn't really required. Because we're already removingdigits-serverin this PR, I think it makes sense to remove both at once.