Minor modification to support DIGITS for Windows #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casting histogram to float32 to ensure correct format in JSON.
| @@ -242,6 +242,9 @@ def apply(self): | |||
| os.environ['PYTHONPATH'] = '%s:%s' % (p, os.environ.get('PYTHONPATH')) | |||
|
|
|||
| try: | |||
| # for Windows environment, loading h5py before caffe solves the issue mentioned in | |||
| # https://github.com/NVIDIA/DIGITS/issues/47#issuecomment-206292824 | |||
| import h5py | |||
There was a problem hiding this comment.
Can you put this before the try/catch block? If someone didn't install h5py, then they would get a misleading error: Did you forget to "make pycaffe"?.
|
Thanks for the comment. I moved 'import h5py' outside the try/except block to avoid potential confusion. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading h5py before caffe to solve hdf5 dll issue.
Casting histogram to float32 to ensure correct format in JSON.