-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View extension framework #756
Conversation
f69c5b6
to
c701549
Compare
I tested the gradient workflow and it's working well for me. But isn't it supposed to draw a red arrow in the direction of the gradient when you test an image? I thought I saw a screenshot from you that did that. Maybe I'll find out what I'm doing wrong when I dig into the code review ... |
|
||
view_extensions = [ | ||
# set show=True if extension should be listed in known extensions | ||
{'class': rawData.Visualization, 'show': True}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should also show the gradient datasets if we're showing the models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, my bad. I got confused.
Our new URLs seem a little weird: # classification (old)
/datasets/images/classification/new
/models/images/classification/new
# generic (old)
/datasets/images/generic/new
/models/images/generic/new
# gradients (new)
/datasets/generic/new/image-gradients
/models/images/generic/new?extension_id=image-gradients Why the inconsistency? I like the move to |
The generic datasets now support any 3D data (barring bugs). I initially wanted to add generic models too to handle any 3D data but realized that it would be a huge change. We'd have to change a lot of the training and inference paths. So I thought as a first step we could use the existing image/generic models with both the image/generic datasets and the generic datasets.
No strong reason actually - I didn't know how to make the |
Ok, I figured you had a good reason for not creating
This oughta work: |
c701549
to
3061efe
Compare
I have updated the "Generic datasets" commit to fix this. For image gradients, routes now look like:
If the extension ID is unspecified in the model creation URL, then this defaults to the "other" kind of datasets. |
398315c
to
ded7a79
Compare
ded7a79
to
49e4173
Compare
View extension framework
This implements a visualization framework along the lines of:
Depends on #731
A
rawData
view extension is added and selected by default to show the network output in the same way as in the original generic type of networks.