Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View extension framework #756

Merged
merged 2 commits into from
May 25, 2016
Merged

Conversation

gheinrich
Copy link
Contributor

This implements a visualization framework along the lines of:

data-classes

Depends on #731

A rawData view extension is added and selected by default to show the network output in the same way as in the original generic type of networks.

@gheinrich gheinrich force-pushed the dev/view-extensions branch 3 times, most recently from f69c5b6 to c701549 Compare May 19, 2016 12:57
@lukeyeager
Copy link
Member

I tested the gradient workflow and it's working well for me. But isn't it supposed to draw a red arrow in the direction of the gradient when you test an image? I thought I saw a screenshot from you that did that. Maybe I'll find out what I'm doing wrong when I dig into the code review ...


view_extensions = [
# set show=True if extension should be listed in known extensions
{'class': rawData.Visualization, 'show': True},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should also show the gradient datasets if we're showing the models

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the rawData visualization - it's just showing the raw data. To see the little arrows you need to select the gradient visualization (which isn't in this PR - it's in e8001f8 if you're curious to try). The screenshot was on the PR description for #735 - sorry it's confusing!)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, my bad. I got confused.

@lukeyeager
Copy link
Member

Our new URLs seem a little weird:

# classification (old)
/datasets/images/classification/new
/models/images/classification/new
# generic (old)
/datasets/images/generic/new
/models/images/generic/new
# gradients (new)
/datasets/generic/new/image-gradients
/models/images/generic/new?extension_id=image-gradients

Why the inconsistency? I like the move to /[datasets|models]/generic/new, why doesn't that work for models? And why does one specify the extension in the query string but the other doesn't?

@gheinrich
Copy link
Contributor Author

I like the move to /[datasets|models]/generic/new, why doesn't that work for models?

The generic datasets now support any 3D data (barring bugs). I initially wanted to add generic models too to handle any 3D data but realized that it would be a huge change. We'd have to change a lot of the training and inference paths. So I thought as a first step we could use the existing image/generic models with both the image/generic datasets and the generic datasets.

And why does one specify the extension in the query string but the other doesn't?

No strong reason actually - I didn't know how to make the inference_id parameter optional when using URLs in the form of /models/images/generic/new/<extension_id>.

@lukeyeager
Copy link
Member

Ok, I figured you had a good reason for not creating /models/generic/. I agree we don't need to do all that work now, but I look forward to being able to do it eventually and to convert all datasets to /datasets/generic and all models to /models/generic, or whatever we end up calling them.

I didn't know how to make the inference_id parameter optional when using URLs in the form of /models/images/generic/new/<extension_id>.

This oughta work:
http://stackoverflow.com/questions/14032066/flask-optional-url-parameters

@gheinrich
Copy link
Contributor Author

And why does one specify the extension in the query string but the other doesn't?

I have updated the "Generic datasets" commit to fix this. For image gradients, routes now look like:

# gradients (new)
/datasets/generic/new/image-gradients
/models/images/generic/new/image-gradients

If the extension ID is unspecified in the model creation URL, then this defaults to the "other" kind of datasets.

@gheinrich gheinrich force-pushed the dev/view-extensions branch 6 times, most recently from 398315c to ded7a79 Compare May 23, 2016 10:00
@lukeyeager lukeyeager merged commit d5483f0 into NVIDIA:master May 25, 2016
@gheinrich gheinrich deleted the dev/view-extensions branch November 30, 2016 16:51
SlipknotTN pushed a commit to cynnyx/DIGITS that referenced this pull request Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants