Add a hash to cached assets (.js and .css files) #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requested at #734 (comment) |
| @@ -1,11 +1,12 @@ | |||
|
|
|||
jmancewicz
added a commit
to jmancewicz/DIGITS
that referenced
this pull request
Jul 13, 2016
jmancewicz
added a commit
to jmancewicz/DIGITS
that referenced
this pull request
Jul 13, 2016
jmancewicz
added a commit
to jmancewicz/DIGITS
that referenced
this pull request
Jul 13, 2016
|
@lukeyeager, I think I hit all your points and simplified the dir_hash function a bit. |
|
Code looks good. I verified the fix. I'll merge once TravisCI passes (not because I think it won't pass, but because I like to see check marks by merged PRs 😃). |
lukeyeager
added a commit
to lukeyeager/DIGITS
that referenced
this pull request
Aug 25, 2016
lukeyeager
added a commit
that referenced
this pull request
Aug 26, 2016
Add version hash (from #904) to PretrainedModel.js
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
Add a hash to cached assets (.js and .css files)
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
Add version hash (from NVIDIA#904) to PretrainedModel.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving between versions of DIGITS changes in javascript content can cause render issues.
git checkout 74afccb
reload the DIGITS home page, click on a job name to navigate to a job page,
git checkout d0b407a
Use the DIGITS link in the upper left corner to navigate back to the home page.
The content of the app javascript file has changed, however the file is cached in session by the name, and the name has not changed. To flush the cache a hash for the static directory is being added to the url for the .js and .css files.