Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new bucket when param require new bucket #762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wangxicoding
Copy link
Contributor

Problem description

Suppose we have three parameters a, b, c of size 10, 4, 8, and the last parameter is shared_embedding, dp = 4. According to the previous implementation, the result will be (while False will be judged by assert data_start_index % self.data_parallel_world_size == 0 during c param iter):

param data_start_index data_end_index
a 0 10
b 10 14
c(emb) 14 22

After fix

param data_start_index data_end_index
a 0 10
b 10 14
c(emb) 16 24

Copy link

github-actions bot commented Jun 1, 2024

Marking as stale. No activity in 60 days.

@github-actions github-actions bot added the stale No activity in 60 days on issue or PR label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity in 60 days on issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant