Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support same app for all sites in Job API #2714

Merged
merged 11 commits into from
Jul 30, 2024
Merged

Support same app for all sites in Job API #2714

merged 11 commits into from
Jul 30, 2024

Conversation

holgerroth
Copy link
Collaborator

Fixes # .

Description

Introduces to_server() and to_clients() routines to support defining the same app for all sites in Job API.
Adds n_clients option to job.simulator_run() to still be able to define number of clients for simulation.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth
Copy link
Collaborator Author

/build

@holgerroth
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good, added some comments

nvflare/job_config/fed_job.py Outdated Show resolved Hide resolved
nvflare/job_config/fed_job.py Outdated Show resolved Hide resolved
nvflare/job_config/fed_job.py Show resolved Hide resolved
nvflare/job_config/fed_job.py Show resolved Hide resolved
nvflare/job_config/fed_job.py Outdated Show resolved Hide resolved
nvflare/job_config/fed_job.py Show resolved Hide resolved
yhwen
yhwen requested changes Jul 30, 2024
View reviewed changes
nvflare/job_config/fed_job.py Outdated Show resolved Hide resolved
yhwen
yhwen previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@yhwen yhwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the method naming for now. Need documentations to explain the usage.

@holgerroth
Copy link
Collaborator Author

@YuanTingHsieh addressed your comments.

@holgerroth holgerroth enabled auto-merge (squash) July 30, 2024 19:49
@holgerroth
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks LGTM

@holgerroth holgerroth merged commit 1ef5207 into NVIDIA:main Jul 30, 2024
16 checks passed
@holgerroth holgerroth deleted the job_all_sites branch July 30, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yhwen yhwen yhwen left review comments

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holgerroth @yhwen @YuanTingHsieh