Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added engine.add_component() function -- 2.4 branch #2622

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Added engine.add_component() function -- 2.4 branch #2622

merged 1 commit into from
Jun 7, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jun 7, 2024

Fixes # .

Description

Enable the add_component() function to engine. Also add the handlers if needed.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yhwen yhwen requested a review from nvidianz June 7, 2024 16:05
@nvidianz nvidianz merged commit 767fcac into NVIDIA:2.4 Jun 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yhwen @nvidianz