Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add packed dataset #181

Open
gshennvm opened this issue May 20, 2024 · 2 comments
Open

add packed dataset #181

gshennvm opened this issue May 20, 2024 · 2 comments

Comments

@gshennvm
Copy link
Collaborator

in aligner we should pack the dataset along the sequence dimension when training. This will be good for CP and training performance.
@lifan-yuan
Copy link

@gshennvm @aaronp24 @odelalleau @tmfs10 @lukeyeager Any plan on implementing this feature? 👀

@RadhaGulhane13 RadhaGulhane13 mentioned this issue Aug 2, 2024
Closed
8 tasks
@ashors1
Copy link
Collaborator

ashors1 commented Sep 5, 2024

Sequence packing for SFT is merged: #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lifan-yuan @ashors1 @gshennvm