Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jp itn #101

Closed
wants to merge 240 commits into from
Closed

Jp itn #101

wants to merge 240 commits into from

Conversation

BuyuanCui
Copy link
Collaborator

@BuyuanCui BuyuanCui commented Sep 7, 2023

What does this PR do ?

Merge to main for Japanese support on cardinal, ordinal, time, date, fraction, decimal support
Add a one line overview of what this PR aims to accomplish.
This is a PR for Japanese ITN support.

Before your PR is "Ready for review"

Pre checks:

  • [*] Have you signed your commits? Use git commit -s to sign.
  • [*] Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • [*] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • [*] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • [*] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • [*] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • [*] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • [*] Remove import guards (try import: ... except: ...) if not already done.
  • [*] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • [*] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • [*] New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

BuyuanCui and others added 28 commits July 6, 2023 09:06
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
Signed-off-by: BuyuanCui <alexcui1994@gmail.com>
BuyuanCui and others added 14 commits February 16, 2024 15:54
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
for more information, see https://pre-commit.ci

Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
… into jp_itn_20231212

Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Signed-off-by: Alex Cui <alexcui1994@gmail.com>
Copy link

github-actions bot commented Mar 8, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 8, 2024
Copy link

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Mar 15, 2024
@BuyuanCui BuyuanCui reopened this Apr 19, 2024
@github-actions github-actions bot removed the Stale label Apr 20, 2024
@ekmb
Copy link
Collaborator

ekmb commented Apr 30, 2024

@BuyuanCui should we close this PR in favor of #141 ?

Copy link

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 15, 2024
Copy link

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet