Update to Lightning 1.0.3 #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Jason <jasoli@nvidia.com>
tkornuta-nvidia
pushed a commit
that referenced
this pull request
Oct 22, 2020
* minor changes to PTL 1.0 support (#1312) * PTL 1.0 support Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * ipdb removal Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fix to unequal length of correct counts Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fixed test Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> * Close opened file to prevent IOError (#1308) * Close opened file to prevent IOError Close an opened text file when done, in order to prevent reaching the number of opened files. Signed-off-by: Mpho Mphego <mpho112@gmail.com> * style Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> * moved all tensorboard logs to self.log (#1317) * moved all tensorboard logs to self.log Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * PTL upgrade change for classification models Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Patch QA training_step (#1316) * fix training_step Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * upgrade to PTL 1.0.2 (#1318) Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * pinning nemo version for colab (#1322) Signed-off-by: ericharper <complex451@gmail.com> * Update to Lightning 1.0.3 (#1323) * update add_state and loading checkpoints Signed-off-by: Jason <jasoli@nvidia.com> * syntax error Signed-off-by: Jason <jasoli@nvidia.com> * modelPT constructor bugfix (#1326) Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * EncDecSpeakerLabelModel exportable (#1320) Signed-off-by: Sergei Nikolaev <snikolaev@nvidia.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> Co-authored-by: Mpho Mphego <mmphego@ska.ac.za> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Sergei Nikolaev <drnikolaev@users.noreply.github.com>
ekmb
pushed a commit
that referenced
this pull request
Oct 23, 2020
* update add_state and loading checkpoints Signed-off-by: Jason <jasoli@nvidia.com> * syntax error Signed-off-by: Jason <jasoli@nvidia.com>
tkornuta-nvidia
pushed a commit
that referenced
this pull request
Oct 23, 2020
* changes for tlt Signed-off-by: ekmb <ebakhturina@nvidia.com> * minor changes to PTL 1.0 support (#1312) * PTL 1.0 support Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * ipdb removal Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fix to unequal length of correct counts Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fixed test Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> * Close opened file to prevent IOError (#1308) * Close opened file to prevent IOError Close an opened text file when done, in order to prevent reaching the number of opened files. Signed-off-by: Mpho Mphego <mpho112@gmail.com> * style Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> * moved all tensorboard logs to self.log (#1317) * moved all tensorboard logs to self.log Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * PTL upgrade change for classification models Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Patch QA training_step (#1316) * fix training_step Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * upgrade to PTL 1.0.2 (#1318) Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * pinning nemo version for colab (#1322) Signed-off-by: ericharper <complex451@gmail.com> * Update to Lightning 1.0.3 (#1323) * update add_state and loading checkpoints Signed-off-by: Jason <jasoli@nvidia.com> * syntax error Signed-off-by: Jason <jasoli@nvidia.com> * modelPT constructor bugfix (#1326) Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * EncDecSpeakerLabelModel exportable (#1320) Signed-off-by: Sergei Nikolaev <snikolaev@nvidia.com> * remove unused import Signed-off-by: ekmb <ebakhturina@nvidia.com> * CTC decoders (#1319) * Added back CTC beam search decoder with LM Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Added beam search decoder build step in Dockerfile Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Added ASR offline inference notebook Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Removed unused imports Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> * .nemo to single .onnx CLI converter script for ASR models (#1332) Signed-off-by: Sergei Nikolaev <snikolaev@nvidia.com> * Update max_step calculation in LR Scheduler (#1336) * V1 of max_steps fix and add test Signed-off-by: Jason <jasoli@nvidia.com> * update test Signed-off-by: Jason <jasoli@nvidia.com> * enable all tests Signed-off-by: Jason <jasoli@nvidia.com> * style Signed-off-by: Jason <jasoli@nvidia.com> * avoid double testing Signed-off-by: Jason <jasoli@nvidia.com> * add cleanup to test Signed-off-by: Jason <jasoli@nvidia.com> * add cleanup to test Signed-off-by: Jason <jasoli@nvidia.com> * typo Signed-off-by: Jason <jasoli@nvidia.com> * 'deprecated' Signed-off-by: Jason <jasoli@nvidia.com> * fixes Signed-off-by: Jason <jasoli@nvidia.com> * Update exp_manager for Lightning 1.0 (#1324) * 1st prototype Signed-off-by: Jason <jasoli@nvidia.com> * typo Signed-off-by: Jason <jasoli@nvidia.com> * update Signed-off-by: Jason <jasoli@nvidia.com> * update exp_manager Signed-off-by: Jason <jasoli@nvidia.com> * syntax Signed-off-by: Jason <jasoli@nvidia.com> * remove path from typehint Signed-off-by: Jason <jasoli@nvidia.com> * learn better python Signed-off-by: Jason <jasoli@nvidia.com> * update checkpoint loading Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> * types updated Signed-off-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> Co-authored-by: Mpho Mphego <mmphego@ska.ac.za> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Sergei Nikolaev <drnikolaev@users.noreply.github.com> Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com>
okuchaiev
added a commit
that referenced
this pull request
Oct 27, 2020
* Token Classification with TLT (#1306) * tlt training works Signed-off-by: ekmb <ebakhturina@nvidia.com> * refactred data desc class Signed-off-by: ekmb <ebakhturina@nvidia.com> * update preprocessing and stats Signed-off-by: ekmb <ebakhturina@nvidia.com> * updated for tlt Signed-off-by: ekmb <ebakhturina@nvidia.com> * clean up Signed-off-by: ekmb <ebakhturina@nvidia.com> * Question answering tlt (#1305) * refactor qa to not use dataloader arguments outside of dataloader functions, use artifacts Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * delete mode from config and make test an evaluation Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add inference script Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix bug Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * Update OmegaConf & Hydra (#1303) * update req Signed-off-by: Jason <jasoli@nvidia.com> * update jenkins Signed-off-by: Jason <jasoli@nvidia.com> * update Signed-off-by: Jason <jasoli@nvidia.com> * update Signed-off-by: Jason <jasoli@nvidia.com> * update Signed-off-by: Jason <jasoli@nvidia.com> * remove print Signed-off-by: Jason <jasoli@nvidia.com> * disable test (#1310) Signed-off-by: Jason <jasoli@nvidia.com> * TTS Collection Cleanup (#1304) * update yamls Signed-off-by: Jason <jasoli@nvidia.com> * OperationMode change Signed-off-by: Jason <jasoli@nvidia.com> * drop experimental and unneeded functions, fix dataclass Signed-off-by: Jason <jasoli@nvidia.com> * update notebook Signed-off-by: Jason <jasoli@nvidia.com> * update docs; ipython notebook; fixes Signed-off-by: Jason <jasoli@nvidia.com> * update Signed-off-by: Jason <jasoli@nvidia.com> * unused import Signed-off-by: Jason <jasoli@nvidia.com> * style Signed-off-by: Jason <jasoli@nvidia.com> * update pad_value Signed-off-by: Jason <jasoli@nvidia.com> * style Signed-off-by: Jason <jasoli@nvidia.com> * fix Preprocessor dataclass Signed-off-by: Jason <jasoli@nvidia.com> * update tacotron2 labels Signed-off-by: Jason <jasoli@nvidia.com> * move labels Signed-off-by: Jason <jasoli@nvidia.com> * typo Signed-off-by: Jason <jasoli@nvidia.com> * typos Signed-off-by: Jason <jasoli@nvidia.com> * update taco2 Signed-off-by: Jason <jasoli@nvidia.com> * changed dataset modes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add num_worker, drop_last and pin_memory to dataloader specific section too Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix nan issue Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * delete unused import Signed-off-by: Yang Zhang <yangzhang@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> * Update tlt integration branch (#1331) * minor changes to PTL 1.0 support (#1312) * PTL 1.0 support Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * ipdb removal Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fix to unequal length of correct counts Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fixed test Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> * Close opened file to prevent IOError (#1308) * Close opened file to prevent IOError Close an opened text file when done, in order to prevent reaching the number of opened files. Signed-off-by: Mpho Mphego <mpho112@gmail.com> * style Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> * moved all tensorboard logs to self.log (#1317) * moved all tensorboard logs to self.log Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * PTL upgrade change for classification models Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Patch QA training_step (#1316) * fix training_step Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * upgrade to PTL 1.0.2 (#1318) Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * pinning nemo version for colab (#1322) Signed-off-by: ericharper <complex451@gmail.com> * Update to Lightning 1.0.3 (#1323) * update add_state and loading checkpoints Signed-off-by: Jason <jasoli@nvidia.com> * syntax error Signed-off-by: Jason <jasoli@nvidia.com> * modelPT constructor bugfix (#1326) Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * EncDecSpeakerLabelModel exportable (#1320) Signed-off-by: Sergei Nikolaev <snikolaev@nvidia.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> Co-authored-by: Mpho Mphego <mmphego@ska.ac.za> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Sergei Nikolaev <drnikolaev@users.noreply.github.com> * QA squad update tutorial and example script with usage examples (#1325) * refactor qa to not use dataloader arguments outside of dataloader functions, use artifacts Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * delete mode from config and make test an evaluation Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add inference script Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix bug Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * changed dataset modes Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add num_worker, drop_last and pin_memory to dataloader specific section too Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix nan issue Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * delete unused import Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * add more params to inference Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix inference and add all model usages to example script Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * added qa task description to script Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * adjusted QA tutorial to new squad changes, updated example script with more use cases Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * fix code style Signed-off-by: Yang Zhang <yangzhang@nvidia.com> * Punctuation model with TLT (#1314) * changes for tlt Signed-off-by: ekmb <ebakhturina@nvidia.com> * minor changes to PTL 1.0 support (#1312) * PTL 1.0 support Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * ipdb removal Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fix to unequal length of correct counts Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * fixed test Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> * Close opened file to prevent IOError (#1308) * Close opened file to prevent IOError Close an opened text file when done, in order to prevent reaching the number of opened files. Signed-off-by: Mpho Mphego <mpho112@gmail.com> * style Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> * moved all tensorboard logs to self.log (#1317) * moved all tensorboard logs to self.log Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * PTL upgrade change for classification models Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Patch QA training_step (#1316) * fix training_step Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * limit jenkins run with train_ds.num_samples rather than trainer.max_steps Signed-off-by: ericharper <complex451@gmail.com> * upgrade to PTL 1.0.2 (#1318) Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * pinning nemo version for colab (#1322) Signed-off-by: ericharper <complex451@gmail.com> * Update to Lightning 1.0.3 (#1323) * update add_state and loading checkpoints Signed-off-by: Jason <jasoli@nvidia.com> * syntax error Signed-off-by: Jason <jasoli@nvidia.com> * modelPT constructor bugfix (#1326) Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * EncDecSpeakerLabelModel exportable (#1320) Signed-off-by: Sergei Nikolaev <snikolaev@nvidia.com> * remove unused import Signed-off-by: ekmb <ebakhturina@nvidia.com> * CTC decoders (#1319) * Added back CTC beam search decoder with LM Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Added beam search decoder build step in Dockerfile Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Added ASR offline inference notebook Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Removed unused imports Signed-off-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> * .nemo to single .onnx CLI converter script for ASR models (#1332) Signed-off-by: Sergei Nikolaev <snikolaev@nvidia.com> * Update max_step calculation in LR Scheduler (#1336) * V1 of max_steps fix and add test Signed-off-by: Jason <jasoli@nvidia.com> * update test Signed-off-by: Jason <jasoli@nvidia.com> * enable all tests Signed-off-by: Jason <jasoli@nvidia.com> * style Signed-off-by: Jason <jasoli@nvidia.com> * avoid double testing Signed-off-by: Jason <jasoli@nvidia.com> * add cleanup to test Signed-off-by: Jason <jasoli@nvidia.com> * add cleanup to test Signed-off-by: Jason <jasoli@nvidia.com> * typo Signed-off-by: Jason <jasoli@nvidia.com> * 'deprecated' Signed-off-by: Jason <jasoli@nvidia.com> * fixes Signed-off-by: Jason <jasoli@nvidia.com> * Update exp_manager for Lightning 1.0 (#1324) * 1st prototype Signed-off-by: Jason <jasoli@nvidia.com> * typo Signed-off-by: Jason <jasoli@nvidia.com> * update Signed-off-by: Jason <jasoli@nvidia.com> * update exp_manager Signed-off-by: Jason <jasoli@nvidia.com> * syntax Signed-off-by: Jason <jasoli@nvidia.com> * remove path from typehint Signed-off-by: Jason <jasoli@nvidia.com> * learn better python Signed-off-by: Jason <jasoli@nvidia.com> * update checkpoint loading Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> * types updated Signed-off-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> Co-authored-by: Mpho Mphego <mmphego@ska.ac.za> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Sergei Nikolaev <drnikolaev@users.noreply.github.com> Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> * Adding inference from examples for Intent and Slot model (#1338) Signed-off-by: Vlad Getselevich <vgetselevich@nvidia.com> * Intent slot (#1358) * Adding inference from examples for Intent and Slot model Signed-off-by: Vlad Getselevich <vgetselevich@nvidia.com> * Adding Inference from examples to the Tutorial Signed-off-by: Vlad Getselevich <vgetselevich@nvidia.com> Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com> Co-authored-by: ekmb <ebakhturina@nvidia.com> Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> Co-authored-by: Mpho Mphego <mmphego@ska.ac.za> Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com> Co-authored-by: Sergei Nikolaev <drnikolaev@users.noreply.github.com> Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com> Co-authored-by: Vlad Getselevich <vgetselevich@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1297