Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmt service update #1909

Merged
merged 10 commits into from Mar 24, 2021
Merged

Nmt service update #1909

merged 10 commits into from Mar 24, 2021

Conversation

okuchaiev
Copy link
Member

No description provided.

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
@okuchaiev okuchaiev requested a review from titu1994 March 23, 2021 16:18
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

examples/nlp/machine_translation/nmt_webapp/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@okuchaiev okuchaiev merged commit 6594dd6 into r1.0.0rc1 Mar 24, 2021
@blisc blisc deleted the nmt_service_update branch April 1, 2021 16:46
vadam5 pushed a commit to vadam5/NeMo that referenced this pull request Apr 9, 2021
* nmt service updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* remove Japanese from UI

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* switch to localhost

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
vadam5 pushed a commit to vadam5/NeMo that referenced this pull request Apr 12, 2021
* nmt service updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* remove Japanese from UI

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* switch to localhost

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
michalivne pushed a commit to michalivne/NeMo that referenced this pull request Jun 23, 2021
* nmt service updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* remove Japanese from UI

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* switch to localhost

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Signed-off-by: Micha Livne <mlivne@nvidia.com>
mousebaiker pushed a commit to mousebaiker/NeMo that referenced this pull request Jul 8, 2021
* nmt service updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* updates

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* remove Japanese from UI

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>

* switch to localhost

Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants