Link updates in docs and notebooks and typo fix #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: fayejf <fayejf07@gmail.com>
ericharper
reviewed
Jun 28, 2021
| @@ -42,7 +42,7 @@ | |||
| "\n", | |||
| "In this tutorial, we shall first demonstrate how to perform diarization with a oracle VAD time stamps (we assume we already have speech time stamps) and pretrained speaker verification model which can be found in tutorial for [Speaker and Recognition and Verification in NeMo](https://github.com/NVIDIA/NeMo/blob/main/tutorials/speaker_recognition/Speaker_Recognition_Verification.ipynb).\n", | |||
| "\n", | |||
| "In [second part](#ORACLE-VAD-DIARIZATION) we show how to perform VAD and then diarization if ground truth timestamped speech were not available (non-oracle VAD). We also have tutorials for [VAD training in NeMo](https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/06_Voice_Activiy_Detection.ipynb) and [online offline microphone inference](https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/07_Online_Offline_Microphone_VAD_Demo.ipynb), where you can custom your model and training/finetuning on your own data.\n", | |||
| "In [second part](#ORACLE-VAD-DIARIZATION) we show how to perform VAD and then diarization if ground truth timestamped speech were not available (non-oracle VAD). We also have tutorials for [VAD training in NeMo](https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/06_Voice_Activity_Detection.ipynb) and [online offline microphone inference](https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/07_Online_Offline_Microphone_VAD_Demo.ipynb), where you can custom your model and training/finetuning on your own data.\n", | |||
There was a problem hiding this comment.
Notebook link is still main here
There was a problem hiding this comment.
Thanks for catching it! Updated and found more runaways
Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: fayejf <fayejf07@gmail.com>
titu1994
approved these changes
Jun 28, 2021
| @@ -508,7 +508,7 @@ Note the ``+`` symbol is needed if we're not adding the arguments to the YAML co | |||
| Megatron | |||
| ^^^^^^^^ | |||
|
|
|||
| We have provided a `Megatron config file <https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/machine_translation/conf/megatron.yaml>`__ | |||
| We have provided a `Megatron config file <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/machine_translation/conf/megatron.yaml>`__ | |||
There was a problem hiding this comment.
This link doesn't work. @ericharper was this config added after 1.0 release ?
There was a problem hiding this comment.
@titu1994 could I merge it? Or we shall wait until the stable branch is ready?
titu1994
added a commit
that referenced
this pull request
Jul 2, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (#2378) * update branch Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (#2380) * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * instantiate with NLPDDPPlugin with num_nodes from trainer config Signed-off-by: ericharper <complex451@gmail.com> * Update ASR scripts for tokenizer building and tarred dataset building (#2381) * Update ASR scripts for tokenizer building and tarred dataset building Signed-off-by: smajumdar <titu1994@gmail.com> * Update container Signed-off-by: smajumdar <titu1994@gmail.com> * Add STT Zh Citrinet 1024 Gamma 0.25 model Signed-off-by: smajumdar <titu1994@gmail.com> * Update notebook (#2391) Signed-off-by: smajumdar <titu1994@gmail.com> * ASR Notebooks fix for 1.1.0 (#2395) * nb fix for spring clean Signed-off-by: fayejf <fayejf07@gmail.com> * remove outdated instruction Signed-off-by: fayejf <fayejf07@gmail.com> * Mean normalization (#2397) * norm embeddings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * move to utils Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Bugfix adaptive spec augment time masking (#2398) * bugfix adaptive spec augment Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Remove static time width clamping Signed-off-by: smajumdar <titu1994@gmail.com> * Correct typos and issues with notebooks (#2402) * Fix Primer notebook Signed-off-by: smajumdar <titu1994@gmail.com> * Typo Signed-off-by: smajumdar <titu1994@gmail.com> * remove accelerator=DDP in tutorial notebooks to avoid errors. (#2403) Signed-off-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> * [BUGFIX] Megatron in NMT was setting vocab_file to None (#2417) * make vocab_file configurable for megatron in nmt Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * Link updates in docs and notebooks and typo fix (#2416) * typo fix for notebooks Signed-off-by: fayejf <fayejf07@gmail.com> * tiny typo fix in docs Signed-off-by: fayejf <fayejf07@gmail.com> * docs branch->stable Signed-off-by: fayejf <fayejf07@gmail.com> * more docs branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * tutorial links branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * small fix Signed-off-by: fayejf <fayejf07@gmail.com> * add renamed 06 Signed-off-by: fayejf <fayejf07@gmail.com> * more fixes Signed-off-by: fayejf <fayejf07@gmail.com> * Update onnx (#2420) Signed-off-by: smajumdar <titu1994@gmail.com> * Correct version of onnxruntime (#2422) Signed-off-by: smajumdar <titu1994@gmail.com> * update deployment instructions (#2430) Signed-off-by: ericharper <complex451@gmail.com> * Bumping version to 1.1.0 Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * update jenksinfile Signed-off-by: ericharper <complex451@gmail.com> * add upper bounds Signed-off-by: ericharper <complex451@gmail.com> * update readme Signed-off-by: ericharper <complex451@gmail.com> * update requirements Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: khcs <khcs@users.noreply.github.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
mousebaiker
pushed a commit
to mousebaiker/NeMo
that referenced
this pull request
Jul 8, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378) * update branch Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380) * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * instantiate with NLPDDPPlugin with num_nodes from trainer config Signed-off-by: ericharper <complex451@gmail.com> * Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381) * Update ASR scripts for tokenizer building and tarred dataset building Signed-off-by: smajumdar <titu1994@gmail.com> * Update container Signed-off-by: smajumdar <titu1994@gmail.com> * Add STT Zh Citrinet 1024 Gamma 0.25 model Signed-off-by: smajumdar <titu1994@gmail.com> * Update notebook (NVIDIA#2391) Signed-off-by: smajumdar <titu1994@gmail.com> * ASR Notebooks fix for 1.1.0 (NVIDIA#2395) * nb fix for spring clean Signed-off-by: fayejf <fayejf07@gmail.com> * remove outdated instruction Signed-off-by: fayejf <fayejf07@gmail.com> * Mean normalization (NVIDIA#2397) * norm embeddings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * move to utils Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Bugfix adaptive spec augment time masking (NVIDIA#2398) * bugfix adaptive spec augment Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Remove static time width clamping Signed-off-by: smajumdar <titu1994@gmail.com> * Correct typos and issues with notebooks (NVIDIA#2402) * Fix Primer notebook Signed-off-by: smajumdar <titu1994@gmail.com> * Typo Signed-off-by: smajumdar <titu1994@gmail.com> * remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403) Signed-off-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> * [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417) * make vocab_file configurable for megatron in nmt Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * Link updates in docs and notebooks and typo fix (NVIDIA#2416) * typo fix for notebooks Signed-off-by: fayejf <fayejf07@gmail.com> * tiny typo fix in docs Signed-off-by: fayejf <fayejf07@gmail.com> * docs branch->stable Signed-off-by: fayejf <fayejf07@gmail.com> * more docs branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * tutorial links branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * small fix Signed-off-by: fayejf <fayejf07@gmail.com> * add renamed 06 Signed-off-by: fayejf <fayejf07@gmail.com> * more fixes Signed-off-by: fayejf <fayejf07@gmail.com> * Update onnx (NVIDIA#2420) Signed-off-by: smajumdar <titu1994@gmail.com> * Correct version of onnxruntime (NVIDIA#2422) Signed-off-by: smajumdar <titu1994@gmail.com> * update deployment instructions (NVIDIA#2430) Signed-off-by: ericharper <complex451@gmail.com> * Bumping version to 1.1.0 Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * update jenksinfile Signed-off-by: ericharper <complex451@gmail.com> * add upper bounds Signed-off-by: ericharper <complex451@gmail.com> * update readme Signed-off-by: ericharper <complex451@gmail.com> * update requirements Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: khcs <khcs@users.noreply.github.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
pasandi20
pushed a commit
to pasandi20/NeMo
that referenced
this pull request
Jul 13, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378) * update branch Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380) * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * instantiate with NLPDDPPlugin with num_nodes from trainer config Signed-off-by: ericharper <complex451@gmail.com> * Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381) * Update ASR scripts for tokenizer building and tarred dataset building Signed-off-by: smajumdar <titu1994@gmail.com> * Update container Signed-off-by: smajumdar <titu1994@gmail.com> * Add STT Zh Citrinet 1024 Gamma 0.25 model Signed-off-by: smajumdar <titu1994@gmail.com> * Update notebook (NVIDIA#2391) Signed-off-by: smajumdar <titu1994@gmail.com> * ASR Notebooks fix for 1.1.0 (NVIDIA#2395) * nb fix for spring clean Signed-off-by: fayejf <fayejf07@gmail.com> * remove outdated instruction Signed-off-by: fayejf <fayejf07@gmail.com> * Mean normalization (NVIDIA#2397) * norm embeddings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * move to utils Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Bugfix adaptive spec augment time masking (NVIDIA#2398) * bugfix adaptive spec augment Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Remove static time width clamping Signed-off-by: smajumdar <titu1994@gmail.com> * Correct typos and issues with notebooks (NVIDIA#2402) * Fix Primer notebook Signed-off-by: smajumdar <titu1994@gmail.com> * Typo Signed-off-by: smajumdar <titu1994@gmail.com> * remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403) Signed-off-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> * [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417) * make vocab_file configurable for megatron in nmt Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * Link updates in docs and notebooks and typo fix (NVIDIA#2416) * typo fix for notebooks Signed-off-by: fayejf <fayejf07@gmail.com> * tiny typo fix in docs Signed-off-by: fayejf <fayejf07@gmail.com> * docs branch->stable Signed-off-by: fayejf <fayejf07@gmail.com> * more docs branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * tutorial links branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * small fix Signed-off-by: fayejf <fayejf07@gmail.com> * add renamed 06 Signed-off-by: fayejf <fayejf07@gmail.com> * more fixes Signed-off-by: fayejf <fayejf07@gmail.com> * Update onnx (NVIDIA#2420) Signed-off-by: smajumdar <titu1994@gmail.com> * Correct version of onnxruntime (NVIDIA#2422) Signed-off-by: smajumdar <titu1994@gmail.com> * update deployment instructions (NVIDIA#2430) Signed-off-by: ericharper <complex451@gmail.com> * Bumping version to 1.1.0 Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * update jenksinfile Signed-off-by: ericharper <complex451@gmail.com> * add upper bounds Signed-off-by: ericharper <complex451@gmail.com> * update readme Signed-off-by: ericharper <complex451@gmail.com> * update requirements Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: khcs <khcs@users.noreply.github.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> Signed-off-by: Ghasem Pasandi <gpasandi@nvidia.com>
fayejf
added a commit
that referenced
this pull request
Jul 16, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (#2378) * update branch Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (#2380) * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * instantiate with NLPDDPPlugin with num_nodes from trainer config Signed-off-by: ericharper <complex451@gmail.com> * Update ASR scripts for tokenizer building and tarred dataset building (#2381) * Update ASR scripts for tokenizer building and tarred dataset building Signed-off-by: smajumdar <titu1994@gmail.com> * Update container Signed-off-by: smajumdar <titu1994@gmail.com> * Add STT Zh Citrinet 1024 Gamma 0.25 model Signed-off-by: smajumdar <titu1994@gmail.com> * Update notebook (#2391) Signed-off-by: smajumdar <titu1994@gmail.com> * ASR Notebooks fix for 1.1.0 (#2395) * nb fix for spring clean Signed-off-by: fayejf <fayejf07@gmail.com> * remove outdated instruction Signed-off-by: fayejf <fayejf07@gmail.com> * Mean normalization (#2397) * norm embeddings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * move to utils Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Bugfix adaptive spec augment time masking (#2398) * bugfix adaptive spec augment Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Remove static time width clamping Signed-off-by: smajumdar <titu1994@gmail.com> * Correct typos and issues with notebooks (#2402) * Fix Primer notebook Signed-off-by: smajumdar <titu1994@gmail.com> * Typo Signed-off-by: smajumdar <titu1994@gmail.com> * remove accelerator=DDP in tutorial notebooks to avoid errors. (#2403) Signed-off-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> * [BUGFIX] Megatron in NMT was setting vocab_file to None (#2417) * make vocab_file configurable for megatron in nmt Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * Link updates in docs and notebooks and typo fix (#2416) * typo fix for notebooks Signed-off-by: fayejf <fayejf07@gmail.com> * tiny typo fix in docs Signed-off-by: fayejf <fayejf07@gmail.com> * docs branch->stable Signed-off-by: fayejf <fayejf07@gmail.com> * more docs branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * tutorial links branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * small fix Signed-off-by: fayejf <fayejf07@gmail.com> * add renamed 06 Signed-off-by: fayejf <fayejf07@gmail.com> * more fixes Signed-off-by: fayejf <fayejf07@gmail.com> * Update onnx (#2420) Signed-off-by: smajumdar <titu1994@gmail.com> * Correct version of onnxruntime (#2422) Signed-off-by: smajumdar <titu1994@gmail.com> * update deployment instructions (#2430) Signed-off-by: ericharper <complex451@gmail.com> * Bumping version to 1.1.0 Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * update jenksinfile Signed-off-by: ericharper <complex451@gmail.com> * add upper bounds Signed-off-by: ericharper <complex451@gmail.com> * update readme Signed-off-by: ericharper <complex451@gmail.com> * update requirements Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: khcs <khcs@users.noreply.github.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
titu1994
added a commit
to titu1994/NeMo
that referenced
this pull request
Jul 20, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378) * update branch Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380) * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * instantiate with NLPDDPPlugin with num_nodes from trainer config Signed-off-by: ericharper <complex451@gmail.com> * Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381) * Update ASR scripts for tokenizer building and tarred dataset building Signed-off-by: smajumdar <titu1994@gmail.com> * Update container Signed-off-by: smajumdar <titu1994@gmail.com> * Add STT Zh Citrinet 1024 Gamma 0.25 model Signed-off-by: smajumdar <titu1994@gmail.com> * Update notebook (NVIDIA#2391) Signed-off-by: smajumdar <titu1994@gmail.com> * ASR Notebooks fix for 1.1.0 (NVIDIA#2395) * nb fix for spring clean Signed-off-by: fayejf <fayejf07@gmail.com> * remove outdated instruction Signed-off-by: fayejf <fayejf07@gmail.com> * Mean normalization (NVIDIA#2397) * norm embeddings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * move to utils Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Bugfix adaptive spec augment time masking (NVIDIA#2398) * bugfix adaptive spec augment Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Remove static time width clamping Signed-off-by: smajumdar <titu1994@gmail.com> * Correct typos and issues with notebooks (NVIDIA#2402) * Fix Primer notebook Signed-off-by: smajumdar <titu1994@gmail.com> * Typo Signed-off-by: smajumdar <titu1994@gmail.com> * remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403) Signed-off-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> * [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417) * make vocab_file configurable for megatron in nmt Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * Link updates in docs and notebooks and typo fix (NVIDIA#2416) * typo fix for notebooks Signed-off-by: fayejf <fayejf07@gmail.com> * tiny typo fix in docs Signed-off-by: fayejf <fayejf07@gmail.com> * docs branch->stable Signed-off-by: fayejf <fayejf07@gmail.com> * more docs branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * tutorial links branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * small fix Signed-off-by: fayejf <fayejf07@gmail.com> * add renamed 06 Signed-off-by: fayejf <fayejf07@gmail.com> * more fixes Signed-off-by: fayejf <fayejf07@gmail.com> * Update onnx (NVIDIA#2420) Signed-off-by: smajumdar <titu1994@gmail.com> * Correct version of onnxruntime (NVIDIA#2422) Signed-off-by: smajumdar <titu1994@gmail.com> * update deployment instructions (NVIDIA#2430) Signed-off-by: ericharper <complex451@gmail.com> * Bumping version to 1.1.0 Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * update jenksinfile Signed-off-by: ericharper <complex451@gmail.com> * add upper bounds Signed-off-by: ericharper <complex451@gmail.com> * update readme Signed-off-by: ericharper <complex451@gmail.com> * update requirements Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: khcs <khcs@users.noreply.github.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com>
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Sep 17, 2021
* Update notebook branch and Jenkinsfile for 1.1.0 testing (NVIDIA#2378) * update branch Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * [BUGFIX] NMT Multi-node was incorrectly computing num_replicas (NVIDIA#2380) * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * fix property when not using model parallel Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * add debug statement Signed-off-by: ericharper <complex451@gmail.com> * instantiate with NLPDDPPlugin with num_nodes from trainer config Signed-off-by: ericharper <complex451@gmail.com> * Update ASR scripts for tokenizer building and tarred dataset building (NVIDIA#2381) * Update ASR scripts for tokenizer building and tarred dataset building Signed-off-by: smajumdar <titu1994@gmail.com> * Update container Signed-off-by: smajumdar <titu1994@gmail.com> * Add STT Zh Citrinet 1024 Gamma 0.25 model Signed-off-by: smajumdar <titu1994@gmail.com> * Update notebook (NVIDIA#2391) Signed-off-by: smajumdar <titu1994@gmail.com> * ASR Notebooks fix for 1.1.0 (NVIDIA#2395) * nb fix for spring clean Signed-off-by: fayejf <fayejf07@gmail.com> * remove outdated instruction Signed-off-by: fayejf <fayejf07@gmail.com> * Mean normalization (NVIDIA#2397) * norm embeddings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * move to utils Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * Bugfix adaptive spec augment time masking (NVIDIA#2398) * bugfix adaptive spec augment Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Revert freq mask guard Signed-off-by: smajumdar <titu1994@gmail.com> * Remove static time width clamping Signed-off-by: smajumdar <titu1994@gmail.com> * Correct typos and issues with notebooks (NVIDIA#2402) * Fix Primer notebook Signed-off-by: smajumdar <titu1994@gmail.com> * Typo Signed-off-by: smajumdar <titu1994@gmail.com> * remove accelerator=DDP in tutorial notebooks to avoid errors. (NVIDIA#2403) Signed-off-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> * [BUGFIX] Megatron in NMT was setting vocab_file to None (NVIDIA#2417) * make vocab_file configurable for megatron in nmt Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * update docs Signed-off-by: ericharper <complex451@gmail.com> * Link updates in docs and notebooks and typo fix (NVIDIA#2416) * typo fix for notebooks Signed-off-by: fayejf <fayejf07@gmail.com> * tiny typo fix in docs Signed-off-by: fayejf <fayejf07@gmail.com> * docs branch->stable Signed-off-by: fayejf <fayejf07@gmail.com> * more docs branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * tutorial links branch -> stable Signed-off-by: fayejf <fayejf07@gmail.com> * small fix Signed-off-by: fayejf <fayejf07@gmail.com> * add renamed 06 Signed-off-by: fayejf <fayejf07@gmail.com> * more fixes Signed-off-by: fayejf <fayejf07@gmail.com> * Update onnx (NVIDIA#2420) Signed-off-by: smajumdar <titu1994@gmail.com> * Correct version of onnxruntime (NVIDIA#2422) Signed-off-by: smajumdar <titu1994@gmail.com> * update deployment instructions (NVIDIA#2430) Signed-off-by: ericharper <complex451@gmail.com> * Bumping version to 1.1.0 Signed-off-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> * update jenksinfile Signed-off-by: ericharper <complex451@gmail.com> * add upper bounds Signed-off-by: ericharper <complex451@gmail.com> * update readme Signed-off-by: ericharper <complex451@gmail.com> * update requirements Signed-off-by: ericharper <complex451@gmail.com> * update jenkinsfile Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: khcs <khcs@users.noreply.github.com> Co-authored-by: Hoo Chang Shin <hshin@nvidia.com> Co-authored-by: Oleksii Kuchaiev <okuchaiev@nvidia.com> Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo for Voice Activity Detection notebooks/links fix
Update links in docs for branches to stable
Update links in notebooks for branches to stable
Will submit a PR to update links in main branch to main once this PR has been merged to r1.1.0 and main
Please make sure to update stable before release