Drop support for kaldi-io #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <titu1994@gmail.com>
VahidooX
previously approved these changes
Apr 22, 2022
| @@ -183,7 +171,7 @@ def from_file( | |||
| logging.error(f"Loading {audio_file} via pydub raised CouldntDecodeError: `{err}`.") | |||
|
|
|||
| if samples is None: | |||
| libs = "soundfile, kaldiio, and pydub" if HAVE_KALDI_PYDUB else "soundfile" | |||
| libs = "soundfile, kaldiio, and pydub" if HAVE_PYDUB else "soundfile" | |||
There was a problem hiding this comment.
"soundfile, kaldiio, and pydub" -> "soundfile, and pydub"
Need to drop kaldio here.
Signed-off-by: smajumdar <titu1994@gmail.com>
VahidooX
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smajumdar titu1994@gmail.com
What does this PR do ?
Remove all support for kaldi-io.
Reason - very old library that has poor logging format and is very rarely used.
Collection: [ASR]
Changelog
PR Type: