Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Fastpitch Tutorial fix #4044

Merged
merged 4 commits into from
Apr 26, 2022
Merged

[TTS] Fastpitch Tutorial fix #4044

merged 4 commits into from
Apr 26, 2022

Conversation

subhankar-ghosh
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

…2 to FastPitch in tutorials

Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>
Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>
blisc
blisc previously approved these changes Apr 22, 2022
@ericharper ericharper changed the base branch from r1.8.1 to r1.8.2 April 22, 2022 21:09
@ericharper ericharper dismissed blisc’s stale review April 22, 2022 21:09

The base branch was changed.

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 6802011 into r1.8.2 Apr 26, 2022
@ericharper ericharper deleted the fastpitch_fix branch April 26, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants