Generalize adapter merge strategy for future adapters #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
titu1994
force-pushed
the
adapters_refactor
branch
from
0018467
to
95acbfb
Compare
nithinraok
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smajumdar titu1994@gmail.com
What does this PR do ?
Generalize the way adapters are merged with their input, so as to allow more complicated adapters for the future, such as SimAdapter or MetaAdapter
Collection: [Core, ASR]
Changelog
AbstractAdapterStrategyas a base strategy that is used for other adapter strategiesResidualAddAdapterStrategyfor simple residual addition between input and adapter outputBefore your PR is "Ready for review"
Pre checks:
PR Type: