Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASR] Replace all paths with /content/ #4427

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

titu1994
Copy link
Collaborator

Signed-off-by: smajumdar smajumdar@nvidia.com

What does this PR do ?

Fixes paths on ASR Adapter tutorial

Collection: [ASR]

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Signed-off-by: smajumdar <smajumdar@nvidia.com>
@titu1994 titu1994 merged commit 641c3ce into NVIDIA:r1.10.0 Jun 22, 2022
@titu1994 titu1994 deleted the fix_asr_doc branch June 22, 2022 20:14
ericharper pushed a commit that referenced this pull request Jun 24, 2022
Signed-off-by: smajumdar <smajumdar@nvidia.com>
ericharper added a commit that referenced this pull request Jun 27, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Punctuation and capitalization tests race condition (#4399)

* Add draft of race condition fixes

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Minor improvements

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* More race condition fixes

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add reconfigure on validation epoch start (#4393)

* Add reconfigure on validation epoch start

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Remove pdb

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* switch branch (#4424)

Signed-off-by: fayejf <fayejf07@gmail.com>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Re-apply fixes from r1.9.0 (#4425)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Replace all with /content/ (#4427)

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (#4405)

* cherry-pick pr 4317 and avoid signoff issue

Signed-off-by: fayejf <fayejf07@gmail.com>

* workaround for mp nb issue

Signed-off-by: fayejf <fayejf07@gmail.com>

* tdqm for mp functions in vad_utils

Signed-off-by: fayejf <fayejf07@gmail.com>

* style fix

Signed-off-by: fayejf <fayejf07@gmail.com>

* reflect comment

Signed-off-by: fayejf <fayejf07@gmail.com>

* remove

Signed-off-by: fayejf <fayejf07@gmail.com>

* [NLP] P&C Fix multi node cache issue, add pynini guard (#4410)

* add sleep to fix multi node cache issue, add pynini guard

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix lgtm

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add tempfile

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* savfe tmp file to the same dir

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: PeganovAnton <peganoff2@mail.ru>

* fix the notebook (#4438)

Signed-off-by: Yi Dong <yidong@nvidia.com>

* update nemo version dialogue tutorial (#4437)

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* unify intent slot dataset util functions in tutorials (#4445)

* Notebook bug fix: add subfolder (#4442)

* add subfolder

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* exp_dir update

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Fix typo in HiFi-GAN config's max steps (#4446)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: PeganovAnton <peganoff2@mail.ru>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Punctuation and capitalization tests race condition (NVIDIA#4399)

* Add draft of race condition fixes

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Minor improvements

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* More race condition fixes

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add reconfigure on validation epoch start (NVIDIA#4393)

* Add reconfigure on validation epoch start

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Remove pdb

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* switch branch (NVIDIA#4424)

Signed-off-by: fayejf <fayejf07@gmail.com>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Re-apply fixes from r1.9.0 (NVIDIA#4425)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Replace all with /content/ (NVIDIA#4427)

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (NVIDIA#4405)

* cherry-pick pr 4317 and avoid signoff issue

Signed-off-by: fayejf <fayejf07@gmail.com>

* workaround for mp nb issue

Signed-off-by: fayejf <fayejf07@gmail.com>

* tdqm for mp functions in vad_utils

Signed-off-by: fayejf <fayejf07@gmail.com>

* style fix

Signed-off-by: fayejf <fayejf07@gmail.com>

* reflect comment

Signed-off-by: fayejf <fayejf07@gmail.com>

* remove

Signed-off-by: fayejf <fayejf07@gmail.com>

* [NLP] P&C Fix multi node cache issue, add pynini guard (NVIDIA#4410)

* add sleep to fix multi node cache issue, add pynini guard

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix lgtm

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add tempfile

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* savfe tmp file to the same dir

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: PeganovAnton <peganoff2@mail.ru>

* fix the notebook (NVIDIA#4438)

Signed-off-by: Yi Dong <yidong@nvidia.com>

* update nemo version dialogue tutorial (NVIDIA#4437)

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* unify intent slot dataset util functions in tutorials (NVIDIA#4445)

* Notebook bug fix: add subfolder (NVIDIA#4442)

* add subfolder

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* exp_dir update

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Fix typo in HiFi-GAN config's max steps (NVIDIA#4446)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: PeganovAnton <peganoff2@mail.ru>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <tbartley@nvidia.com>

Co-authored-by: tbartley94 <tbartley@nvidia.com>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <Travismbartley@gmail.com>

* Punctuation and capitalization tests race condition (NVIDIA#4399)

* Add draft of race condition fixes

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Minor improvements

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* More race condition fixes

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Improve error message

Signed-off-by: PeganovAnton <peganoff2@mail.ru>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix typos

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add reconfigure on validation epoch start (NVIDIA#4393)

* Add reconfigure on validation epoch start

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Remove pdb

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* switch branch (NVIDIA#4424)

Signed-off-by: fayejf <fayejf07@gmail.com>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Correct model card

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Add ASR Results to Docs

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Update info

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Re-apply fixes from r1.9.0 (NVIDIA#4425)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

* Replace all with /content/ (NVIDIA#4427)

Signed-off-by: smajumdar <smajumdar@nvidia.com>

* Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (NVIDIA#4405)

* cherry-pick pr 4317 and avoid signoff issue

Signed-off-by: fayejf <fayejf07@gmail.com>

* workaround for mp nb issue

Signed-off-by: fayejf <fayejf07@gmail.com>

* tdqm for mp functions in vad_utils

Signed-off-by: fayejf <fayejf07@gmail.com>

* style fix

Signed-off-by: fayejf <fayejf07@gmail.com>

* reflect comment

Signed-off-by: fayejf <fayejf07@gmail.com>

* remove

Signed-off-by: fayejf <fayejf07@gmail.com>

* [NLP] P&C Fix multi node cache issue, add pynini guard (NVIDIA#4410)

* add sleep to fix multi node cache issue, add pynini guard

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* fix lgtm

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add tempfile

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* savfe tmp file to the same dir

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: PeganovAnton <peganoff2@mail.ru>

* fix the notebook (NVIDIA#4438)

Signed-off-by: Yi Dong <yidong@nvidia.com>

* update nemo version dialogue tutorial (NVIDIA#4437)

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>

* unify intent slot dataset util functions in tutorials (NVIDIA#4445)

* Notebook bug fix: add subfolder (NVIDIA#4442)

* add subfolder

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* exp_dir update

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Fix typo in HiFi-GAN config's max steps (NVIDIA#4446)

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Deleted cell outputs

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Travis Bartley <Travismbartley@gmail.com>
Co-authored-by: PeganovAnton <peganoff2@mail.ru>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
Co-authored-by: Jocelyn <jocelynh@nvidia.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Zhilin Wang <wangzhilin12061996@hotmail.com>
Co-authored-by: Nick Goncharenko <8766167+nickolyamba@users.noreply.github.com>
Co-authored-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant