Removed NLPDDPPlugin Import check #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
Signed-off-by: Virginia Adams <vadams@nvidia.com>
titu1994
approved these changes
Jul 15, 2022
sarthmit
pushed a commit
to sarthmit/NeMo
that referenced
this pull request
Jul 18, 2022
* Removed NLPDDPPlugin Import check Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * changed app to app_state Signed-off-by: Virginia Adams <vadams@nvidia.com> * moved num workers check back to bottom Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python code reformat Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: sarthmit <sarthmit@gmail.com>
sarthmit
pushed a commit
to sarthmit/NeMo
that referenced
this pull request
Jul 18, 2022
* Removed NLPDDPPlugin Import check Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * changed app to app_state Signed-off-by: Virginia Adams <vadams@nvidia.com> * moved num workers check back to bottom Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python code reformat Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: sarthmit <sarthmit@gmail.com>
itzsimpl
pushed a commit
to itzsimpl/NeMo
that referenced
this pull request
Jul 18, 2022
* Removed NLPDDPPlugin Import check Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * changed app to app_state Signed-off-by: Virginia Adams <vadams@nvidia.com> * moved num workers check back to bottom Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python code reformat Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: Iztok Lebar Bajec <ilb@fri.uni-lj.si>
arendu
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Removed NLPDDPPlugin Import check Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * changed app to app_state Signed-off-by: Virginia Adams <vadams@nvidia.com> * moved num workers check back to bottom Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python code reformat Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: arendu <adithya.r@gmail.com>
Davood-M
pushed a commit
to Davood-M/NeMo
that referenced
this pull request
Aug 9, 2022
* Removed NLPDDPPlugin Import check Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * changed app to app_state Signed-off-by: Virginia Adams <vadams@nvidia.com> * moved num workers check back to bottom Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python code reformat Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* Removed NLPDDPPlugin Import check Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python formatting fix Signed-off-by: Virginia Adams <vadams@nvidia.com> * changed app to app_state Signed-off-by: Virginia Adams <vadams@nvidia.com> * moved num workers check back to bottom Signed-off-by: Virginia Adams <vadams@nvidia.com> * Python code reformat Signed-off-by: Virginia Adams <vadams@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Virginia Adams vadams@nvidia.com
Fixes
max_stepscalculation bug by setting the number of data loading workers to equal data parallel size.Collection: NeMo Core
Changelog
ModelPTclassUsage
N/A same as before
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information