-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mAES algorithm with patches #4662
Conversation
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <smajumdar@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment.
pass | ||
|
||
list_exp.append(new_hyp) | ||
# new_hyp.y_sequence.append(int(k)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we drop this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i kinda kept it cause i might need it for debugging during rnnt beam setup
* First draft implementation fix of maes Signed-off-by: smajumdar <titu1994@gmail.com> * add deduplication checks Signed-off-by: smajumdar <smajumdar@nvidia.com> Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
* First draft implementation fix of maes Signed-off-by: smajumdar <titu1994@gmail.com> * add deduplication checks Signed-off-by: smajumdar <smajumdar@nvidia.com> Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
* First draft implementation fix of maes Signed-off-by: smajumdar <titu1994@gmail.com> * add deduplication checks Signed-off-by: smajumdar <smajumdar@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
What does this PR do ?
Adds the fixes from espnet/espnet#4312 for mAES RNNT beam search.
Collection: [ASR]
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type: