avoid data clipping after convolution with rir samples #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalam-nv
requested changes
Aug 25, 2022
| @@ -332,6 +332,7 @@ def perturb(self, data): | |||
| if not self._shift_impulse: | |||
| impulse_norm = (impulse.samples - min(impulse.samples)) / (max(impulse.samples) - min(impulse.samples)) | |||
| data._samples = signal.fftconvolve(data._samples, impulse_norm, "same") | |||
| data._samples = data._samples / max(abs(data._samples)) | |||
There was a problem hiding this comment.
Please add a comment here about why we are doing this.
jbalam-nv
previously approved these changes
Aug 25, 2022
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
nithinraok
force-pushed
the
fix_fp16_issue_with_augmentation
branch
from
d3718fd
to
ece154c
Compare
jbalam-nv
approved these changes
Aug 25, 2022
piraka9011
pushed a commit
to piraka9011/NeMo
that referenced
this pull request
Aug 25, 2022
* avoid data clipping after convolution with rir samples Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * add comments Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
* avoid data clipping after convolution with rir samples Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * add comments Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* avoid data clipping after convolution with rir samples Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * add comments Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* avoid data clipping after convolution with rir samples Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * add comments Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nithinraok nithinrao.koluguri@gmail.com
What does this PR do ?
Fix nan issue with precision=16
Collection: ASR
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: