Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with Comparison tool info, and slightly change .sh for ea… #5182

Merged
merged 21 commits into from
Nov 21, 2022

Conversation

Jorjeous
Copy link
Collaborator

@Jorjeous Jorjeous commented Oct 17, 2022

…se of use

Signed-off-by: George Zelenfroynd gzelenfroind@nvidia.com

What does this PR do ?

describes new features in documentation

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]
ASR

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

…se of use

Signed-off-by: George Zelenfroynd <gzelenfroind@nvidia.com>
@Jorjeous Jorjeous requested a review from vsl9 October 17, 2022 16:08
@Jorjeous Jorjeous self-assigned this Oct 17, 2022
@okuchaiev
Copy link
Member

/blossom-ci

@okuchaiev
Copy link
Member

/blossom-ci

1 similar comment
@okuchaiev
Copy link
Member

/blossom-ci

@vsl9 vsl9 merged commit fda2c01 into main Nov 21, 2022
1-800-BAD-CODE pushed a commit to 1-800-BAD-CODE/NeMo that referenced this pull request Nov 26, 2022
* Update docs with Comparison tool info
Signed-off-by: George Zelenfroynd <gzelenfroind@nvidia.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com>
Signed-off-by: shane carroll <shane.carroll@utsa.edu>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* Update docs with Comparison tool info
Signed-off-by: George Zelenfroynd <gzelenfroind@nvidia.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* Update docs with Comparison tool info
Signed-off-by: George Zelenfroynd <gzelenfroind@nvidia.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
andrusenkoau pushed a commit to andrusenkoau/NeMo that referenced this pull request Jan 5, 2023
* Update docs with Comparison tool info
Signed-off-by: George Zelenfroynd <gzelenfroind@nvidia.com>
Co-authored-by: Oleksii Kuchaiev <okuchaiev@users.noreply.github.com>
Co-authored-by: Vitaly Lavrukhin <vlavrukhin@nvidia.com>
Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
@titu1994 titu1994 deleted the Update_docs_Comp_tool branch February 23, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants