[TTS] Fix TTS Primer image markup #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan <rlangman@nvidia.com>
blisc
reviewed
Oct 18, 2022
| @@ -144,7 +144,7 @@ | |||
| "While this is the most common structure, there may be fewer or additional steps depending on the use case. For example, some languages do not require G2P and can instead rely on the model to convert raw text/graphemes to spectrogram.\n", | |||
| "\n", | |||
| "<div>\n", | |||
| "<img src=\"https://raw.githubusercontent.com/NVIDIA/NeMo/tts_primer/tutorials/tts/images/tts_pipeline.png\" width=\"500\", height=\"500\"/>\n", | |||
| "<img src=\"https://raw.githubusercontent.com/NVIDIA/NeMo/main/tutorials/tts/images/tts_pipeline.png\" width=\"500\", height=\"500\"/>\n", | |||
There was a problem hiding this comment.
These should probably be stable, which means they'll be broken for now. The alternative is to leave it as main, but you have to update it to stable in the next rc
There was a problem hiding this comment.
actually, double check with jocelyn or som
There was a problem hiding this comment.
I'd say keep it as main for now; I'd rather have the images linked properly with a small TODO than have it broken (especially as a primer tutorial).
redoctopus
approved these changes
Oct 18, 2022
| @@ -144,7 +144,7 @@ | |||
| "While this is the most common structure, there may be fewer or additional steps depending on the use case. For example, some languages do not require G2P and can instead rely on the model to convert raw text/graphemes to spectrogram.\n", | |||
| "\n", | |||
| "<div>\n", | |||
| "<img src=\"https://raw.githubusercontent.com/NVIDIA/NeMo/tts_primer/tutorials/tts/images/tts_pipeline.png\" width=\"500\", height=\"500\"/>\n", | |||
| "<img src=\"https://raw.githubusercontent.com/NVIDIA/NeMo/main/tutorials/tts/images/tts_pipeline.png\" width=\"500\", height=\"500\"/>\n", | |||
There was a problem hiding this comment.
I'd say keep it as main for now; I'd rather have the images linked properly with a small TODO than have it broken (especially as a primer tutorial).
shan18
pushed a commit
to shan18/NeMo
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Ryan <rlangman@nvidia.com>
1-800-BAD-CODE
pushed a commit
to 1-800-BAD-CODE/NeMo
that referenced
this pull request
Nov 13, 2022
Signed-off-by: Ryan <rlangman@nvidia.com> Signed-off-by: 1-800-bad-code <shane.carroll@utsa.edu>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Ryan <rlangman@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Ryan <rlangman@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan rlangman@nvidia.com
What does this PR do ?
Fixes markup issues with github code rendering.
Collection: [TTS]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: