-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOC Optimization in FastPitch #5450
Conversation
8bcfe38
to
060f006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
Could you write a few bullet points in the PR to summarize the changes made?
These are mostly JoC performance optimizations that Adrian had worked on. Like an optimized implementation of |
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com>
060f006
to
3a9b0e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: subhankar-ghosh <subhankar2321@gmail.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
Signed-off-by: subhankar-ghosh subhankar2321@gmail.com
What does this PR do ?
Adds JoC Optimizations in FastPitch
nemo/collections/tts/modules/transformer.py
mas_width1
method innemo/collections/tts/helpers/helpers.py
attn
tolog attn
inbinarize_attention_parallel
and corresponding changes in aligner loss.Collection: [Note which collection this PR will affect]
TTS
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information