No-script TS export, prepared for ONNX export #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
borisfom
force-pushed
the
radtts-unfold
branch
from
aa0b99f
to
9a53880
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
borisfom
changed the title
titu1994
reviewed
Jan 6, 2023
There was a problem hiding this comment.
Overall the export changes look fine. Someone from TTS team should check of the code overall works as expected. Fyi @XuesongYang
|
Seems import check fails with _globals from onnx. Put try catch import guard around it |
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
titu1994
previously approved these changes
Jan 10, 2023
XuesongYang
requested changes
Jan 10, 2023
Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
XuesongYang
approved these changes
Jan 11, 2023
erastorgueva-nv
pushed a commit
that referenced
this pull request
Jan 12, 2023
* Changed unfold to reshape, merged padding chenges * Almost working ONNX export of RadTTS * restored radtts function * Added explicit assume_padded flag * Fixing attn_mask * Fixing unfold * Trying no hx * Back with hx * Made fx only for tracing * Tests annotated * Fully working no-script TS export, prepared for ONNX export * Restored no-autocast block, addressed code review * Fine-tuning autocast option * Protecting InstanceNorm * Forcing eval and param freeze on export Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com> Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* Changed unfold to reshape, merged padding chenges * Almost working ONNX export of RadTTS * restored radtts function * Added explicit assume_padded flag * Fixing attn_mask * Fixing unfold * Trying no hx * Back with hx * Made fx only for tracing * Tests annotated * Fully working no-script TS export, prepared for ONNX export * Restored no-autocast block, addressed code review * Fine-tuning autocast option * Protecting InstanceNorm * Forcing eval and param freeze on export Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boris Fomitchev bfomitchev@nvidia.com
What does this PR do ?
Changed unfold to reshape for inference to be able to export in ONNX.
Also using extra hx parameter to LSTM call to work around Pytorch issues with tracing the hx=None.
Now Torchscript export works without any scripting - so I was also able to get rid of unnecessary autocast=False block.
ONNX export still fails due to internal bugs, even though each part of the network is now ONNX-exportable.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information