validation batch sizing and drop_last controls #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attribute Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
for more information, see https://pre-commit.ci
…into adithyare/drop_last
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Kipok
pushed a commit
to Kipok/NeMo
that referenced
this pull request
Jan 31, 2023
* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <adithya.r@gmail.com> * validation batch sizes and drop last compatibility Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * do not drop last by default Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 prompt learning Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * style Signed-off-by: arendu <adithya.r@gmail.com> * style Signed-off-by: arendu <adithya.r@gmail.com> * drop_last always True for training Signed-off-by: arendu <adithya.r@gmail.com> * typo Signed-off-by: arendu <adithya.r@gmail.com> * pp2 fix Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 adapters Signed-off-by: arendu <adithya.r@gmail.com> * update configs to use validation drop last false Signed-off-by: arendu <adithya.r@gmail.com> Signed-off-by: arendu <adithya.r@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ericharper
pushed a commit
that referenced
this pull request
Jan 31, 2023
* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <adithya.r@gmail.com> * validation batch sizes and drop last compatibility Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * do not drop last by default Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 prompt learning Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * style Signed-off-by: arendu <adithya.r@gmail.com> * style Signed-off-by: arendu <adithya.r@gmail.com> * drop_last always True for training Signed-off-by: arendu <adithya.r@gmail.com> * typo Signed-off-by: arendu <adithya.r@gmail.com> * pp2 fix Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 adapters Signed-off-by: arendu <adithya.r@gmail.com> * update configs to use validation drop last false Signed-off-by: arendu <adithya.r@gmail.com> Signed-off-by: arendu <adithya.r@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ericharper
pushed a commit
that referenced
this pull request
Jan 31, 2023
* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <adithya.r@gmail.com> * validation batch sizes and drop last compatibility Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * do not drop last by default Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 prompt learning Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * style Signed-off-by: arendu <adithya.r@gmail.com> * style Signed-off-by: arendu <adithya.r@gmail.com> * drop_last always True for training Signed-off-by: arendu <adithya.r@gmail.com> * typo Signed-off-by: arendu <adithya.r@gmail.com> * pp2 fix Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 adapters Signed-off-by: arendu <adithya.r@gmail.com> * update configs to use validation drop last false Signed-off-by: arendu <adithya.r@gmail.com> Signed-off-by: arendu <adithya.r@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Kipok
pushed a commit
to Kipok/NeMo
that referenced
this pull request
Jan 31, 2023
* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <adithya.r@gmail.com> * validation batch sizes and drop last compatibility Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * do not drop last by default Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 prompt learning Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * style Signed-off-by: arendu <adithya.r@gmail.com> * style Signed-off-by: arendu <adithya.r@gmail.com> * drop_last always True for training Signed-off-by: arendu <adithya.r@gmail.com> * typo Signed-off-by: arendu <adithya.r@gmail.com> * pp2 fix Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 adapters Signed-off-by: arendu <adithya.r@gmail.com> * update configs to use validation drop last false Signed-off-by: arendu <adithya.r@gmail.com> Signed-off-by: arendu <adithya.r@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* patch to allow using tokenizers without additional_special_tokens_ids attribute Signed-off-by: arendu <adithya.r@gmail.com> * validation batch sizes and drop last compatibility Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * reconfigure batch size per step Signed-off-by: arendu <adithya.r@gmail.com> * do not drop last by default Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 prompt learning Signed-off-by: arendu <adithya.r@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * style Signed-off-by: arendu <adithya.r@gmail.com> * style Signed-off-by: arendu <adithya.r@gmail.com> * drop_last always True for training Signed-off-by: arendu <adithya.r@gmail.com> * typo Signed-off-by: arendu <adithya.r@gmail.com> * pp2 fix Signed-off-by: arendu <adithya.r@gmail.com> * drop last for t5 adapters Signed-off-by: arendu <adithya.r@gmail.com> * update configs to use validation drop last false Signed-off-by: arendu <adithya.r@gmail.com> Signed-off-by: arendu <adithya.r@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR allows use to set the batch sizes for validation. This in turn allows the use to set
validation_drop_last=Falsein the config. Allowing more control over the validation loss calculation and reporting.Collection: [NLP]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information