Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update align.py #6043

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Update align.py #6043

merged 1 commit into from
Feb 17, 2023

Conversation

Slyne
Copy link
Contributor

@Slyne Slyne commented Feb 17, 2023

Add model.eval() to ensure the accuracy.

What does this PR do ?

fix a small bug

Collection: [Note which collection this PR will affect]
no collection would be affected

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

@erastorgueva-nv

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Add model.eval() to ensure the accuracy.


Signed-off-by: Slyne Deng <slynedeng@gmail.com>
@titu1994 titu1994 merged commit 1f2135b into NVIDIA:r1.16.0 Feb 17, 2023
github-actions bot pushed a commit that referenced this pull request Feb 17, 2023
Add model.eval() to ensure the accuracy.

Signed-off-by: Slyne Deng <slynedeng@gmail.com>
titu1994 pushed a commit that referenced this pull request Feb 17, 2023
Add model.eval() to ensure the accuracy.

Signed-off-by: Slyne Deng <slynedeng@gmail.com>
Co-authored-by: Slyne Deng <slynedeng@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
Add model.eval() to ensure the accuracy.

Signed-off-by: Slyne Deng <slynedeng@gmail.com>
Co-authored-by: Slyne Deng <slynedeng@gmail.com>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Add model.eval() to ensure the accuracy.

Signed-off-by: Slyne Deng <slynedeng@gmail.com>
Co-authored-by: Slyne Deng <slynedeng@gmail.com>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants