Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for ExpManager and Exportable frameworks #6165

Merged
merged 2 commits into from Mar 10, 2023
Merged

Update docs for ExpManager and Exportable frameworks #6165

merged 2 commits into from Mar 10, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Adds documentation for Exportable and ExpManager.

Collection: [Core, Docs]

Changelog

  • Fix exp manager subconfig docs
  • Add exp manager loggers
  • Add exp manager EMA docs
  • Update Exportable docs and function docs

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994
Update exp manager docs and refactor loggers
fd2eae5 
Signed-off-by: smajumdar <titu1994@gmail.com>
@titu1994
Update exportable docs
7aea971 
Signed-off-by: smajumdar <titu1994@gmail.com>
@github-actions github-actions bot added the core Changes to NeMo Core label Mar 10, 2023
ericharper
ericharper approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

SeanNaren
SeanNaren approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titu1994 titu1994 merged commit fbe5392 into NVIDIA:main Mar 10, 2023
@titu1994 titu1994 deleted the update_docs branch March 10, 2023 23:33
titu1994 added a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
@titu1994
Update docs for ExpManager and Exportable frameworks (NVIDIA#6165)
58d5d3d 
* Update exp manager docs and refactor loggers

Signed-off-by: smajumdar <titu1994@gmail.com>

* Update exportable docs

Signed-off-by: smajumdar <titu1994@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@titu1994 @hsiehjackson
Update docs for ExpManager and Exportable frameworks (NVIDIA#6165)
74f08ef 
* Update exp manager docs and refactor loggers

Signed-off-by: smajumdar <titu1994@gmail.com>

* Update exportable docs

Signed-off-by: smajumdar <titu1994@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanNaren SeanNaren SeanNaren approved these changes

@ericharper ericharper ericharper approved these changes

@borisfom borisfom Awaiting requested review from borisfom

Assignees
No one assigned
Labels
core Changes to NeMo Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titu1994 @SeanNaren @ericharper