Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix to restore act ckpt #6753

Merged
merged 2 commits into from
May 29, 2023
Merged

Bug fix to restore act ckpt #6753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9ed4bd
Bug fix to restore act ckpt
markelsanz14 May 29, 2023
86a1b44
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 10 additions & 6 deletions nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,16 +1143,20 @@ def _restore_activation_checkpointing_args(self):
_reset_activation_checkpointing_args.
"""
# Restore config values.
self.cfg.activations_checkpoint_granularity = self.last_checkpointing_granularity
self.cfg.activations_checkpoint_method = self.last_checkpointing_method
self.cfg.activations_checkpoint_num_layers = self.last_checkpointing_num_layers
self.cfg.activations_checkpoint_granularity = self.last_activations_checkpoint_granularity
self.cfg.activations_checkpoint_method = self.last_activations_checkpoint_method
self.cfg.activations_checkpoint_num_layers = self.last_activations_checkpoint_num_layers
self.cfg.activations_checkpoint_layers_per_pipeline = self.last_activations_checkpoint_layers_per_pipeline

# Restore model parameters.
for module in self.get_gpt_module_list():
module.language_model.encoder.activations_checkpoint_granularity = self.last_checkpointing_granularity
module.language_model.encoder.activations_checkpoint_method = self.last_checkpointing_method
module.language_model.encoder.activations_checkpoint_num_layers = self.last_checkpointing_num_layers
module.language_model.encoder.activations_checkpoint_granularity = (
self.last_activations_checkpoint_granularity
)
module.language_model.encoder.activations_checkpoint_method = self.last_activations_checkpoint_method
module.language_model.encoder.activations_checkpoint_num_layers = (
self.last_activations_checkpoint_num_layers
)
module.language_model.encoder.activations_checkpoint_layers_per_pipeline = (
self.last_activations_checkpoint_layers_per_pipeline
)
Expand Down