Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] AudioCodecModel training fails with PTL 2.0 #7190

Closed
wants to merge 1 commit into from

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Aug 9, 2023

Currently, AudioCodecModel training fails on main due to changes in PTL 2.0.

What does this PR do ?

This PR is fixing two issues when using PTL 2.0.

Collection: TTS

Changelog

Usage

N/A

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

examples/tts/audio_codec.py Fixed Show fixed Hide fixed
- Support for `training_epoch_end` has been removed in v2.0.0
- Use ddp_find_unused_parameters_true

Signed-off-by: Ante Jukić <ajukic@nvidia.com>
@anteju
Copy link
Collaborator Author

anteju commented Aug 9, 2023

This change is included in #7188.
Closing the PR.

@anteju anteju closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant