Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to accomendate mcore changes #8261

Merged
merged 1 commit into from Jan 27, 2024

Conversation

HuiyingLi
Copy link
Contributor

What does this PR do ?

  • Remove FalconTransformerLayer's sharded_state_dict() to use the mcore 0.5's TransformerLayer's sharded_state_dict() because it supports sharded_dict according to submodules now.
  • add packed_seq_params (introduced in mcore 0.5) args for layer forward.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jan 27, 2024
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
@pablo-garay
Copy link
Collaborator

jenkins

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pablo-garay pablo-garay merged commit 19ce912 into NVIDIA:main Jan 27, 2024
11 checks passed
@HuiyingLi HuiyingLi deleted the huiyingl/falcon_mcore_fixes branch January 28, 2024 03:06
yaoyu-33 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
stevehuang52 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants