New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lhotse AudioToAudio dataset (supports ref recording and embedding) #8477
Conversation
…edding) Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Ante Jukić <ajukic@nvidia.com>
for more information, see https://pre-commit.ci
|
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
844096f
to
aac3db3
Compare
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
jenkins |
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
jenkins |
…dataset (#8619) Signed-off-by: Ante Jukić <ajukic@nvidia.com>
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @pzelasko.
At this point, the main issue is that the prepared lhotse
manifests use absolute paths.
It would be great if we could keep the relative path as in NeMo manifests.
Signed-off-by: Ante Jukić <ajukic@nvidia.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
jenkins |
…onverted manifests Signed-off-by: Ante Jukić <ajukic@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
One change may be required in resolve_array
in cutset
to correctly resolve path.
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pzelasko
jenkins |
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
jenkins |
1 similar comment
jenkins |
jenkins |
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
jenkins |
Everything passed in jenkins, merging |
…VIDIA#8477) * Draft for Lhotse AudioToAudio dataset (supports ref recording and embedding) Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Integrate with speech enhancement models Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix absolute path + write cuts in the output manifest Signed-off-by: Ante Jukić <ajukic@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Support channel selectors for input, reference, and target recordings Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Support on the fly truncation and/or cutting into windows Signed-off-by: Piotr Żelasko <petezor@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Bump min required lhotse version Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Add copyright headers Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Added unit tests checking lhotse dataloader is matching the existing dataset (NVIDIA#8619) Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fix batch unpacking, test_ds, use nemo logging Signed-off-by: Ante Jukić <ajukic@nvidia.com> * fixed some code scanning issues Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fixed a couple CI issues Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Support NeMo-style resolution of relative paths in native lhotse cuts Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Added option to leave original paths or force absolute paths in the converted manifests Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fix support for relative path resolution in lhotse arrays Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix unit tests Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: anteju <108555623+anteju@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
…VIDIA#8477) * Draft for Lhotse AudioToAudio dataset (supports ref recording and embedding) Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Integrate with speech enhancement models Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix absolute path + write cuts in the output manifest Signed-off-by: Ante Jukić <ajukic@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Support channel selectors for input, reference, and target recordings Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Support on the fly truncation and/or cutting into windows Signed-off-by: Piotr Żelasko <petezor@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Bump min required lhotse version Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Add copyright headers Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Added unit tests checking lhotse dataloader is matching the existing dataset (NVIDIA#8619) Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fix batch unpacking, test_ds, use nemo logging Signed-off-by: Ante Jukić <ajukic@nvidia.com> * fixed some code scanning issues Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fixed a couple CI issues Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Support NeMo-style resolution of relative paths in native lhotse cuts Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Added option to leave original paths or force absolute paths in the converted manifests Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fix support for relative path resolution in lhotse arrays Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix unit tests Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: anteju <108555623+anteju@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
…8477) * Draft for Lhotse AudioToAudio dataset (supports ref recording and embedding) Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Integrate with speech enhancement models Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix absolute path + write cuts in the output manifest Signed-off-by: Ante Jukić <ajukic@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Support channel selectors for input, reference, and target recordings Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Support on the fly truncation and/or cutting into windows Signed-off-by: Piotr Żelasko <petezor@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Bump min required lhotse version Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Add copyright headers Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Added unit tests checking lhotse dataloader is matching the existing dataset (#8619) Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fix batch unpacking, test_ds, use nemo logging Signed-off-by: Ante Jukić <ajukic@nvidia.com> * fixed some code scanning issues Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fixed a couple CI issues Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Support NeMo-style resolution of relative paths in native lhotse cuts Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Added option to leave original paths or force absolute paths in the converted manifests Signed-off-by: Ante Jukić <ajukic@nvidia.com> * Fix support for relative path resolution in lhotse arrays Signed-off-by: Piotr Żelasko <petezor@gmail.com> * Fix unit tests Signed-off-by: Piotr Żelasko <petezor@gmail.com> --------- Signed-off-by: Piotr Żelasko <petezor@gmail.com> Signed-off-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: Ante Jukić <ajukic@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: anteju <108555623+anteju@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Ao Tang <aot@nvidia.com>
What does this PR do ?
We're adding several features to enable audio-to-audio dataloading:
Collection: All speech collections
Changelog
Usage
Generally the workflow to use this is as follows:
Then you can instantiate the dataloader like the following:
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkins
on the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information