Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multimodal/speech_cv collection update (Audio Visual Speech Recognition) #8688

Closed
wants to merge 9 commits into from

Conversation

burchim
Copy link
Contributor

@burchim burchim commented Mar 18, 2024

What does this PR do ?

Update the multimodal/speech_cv branch to support audio-visual speech recognition (CTC, RNN-T and Hybrid)

Collection: [multimodal/speech_cv]

Changelog

  • Update speech_cv branch
  • bug fix
  • Add audio-visual datasets
  • Add audio-visual models: (AudioVisualEncDecCTCModelBPE, AudioVisualEncDecCTCModel, AudioVisualEncDecHybridRNNTCTCBPEModel, AudioVisualEncDecHybridRNNTCTCModel, AudioVisualEncDecRNNTBPEModel, AudioVisualEncDecRNNTModel)
  • Add audio-visual modules (FusionModule, InterCTCMixin)
  • Optional ConformerEncoder module 'pre_encode' by setting 'feat_in' to None

Usage

  • You can potentially add a usage example below
import nemo.collections.multimodal.speech_cv as nemo_cv
from omegaconf import OmegaConf

config_path = "model_config.yaml"
params = OmegaConf.load(config_path)

# hybrid CTC/RNN-T BPE audio-visual speech recognition model
model = nemo_cv.models.AudioVisualEncDecHybridRNNTCTCBPEModel(cfg=params.model)

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

burchim and others added 8 commits October 28, 2023 13:50
Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
Copy link
Contributor

github-actions bot commented Apr 2, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Apr 2, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant