NeMo upgrade to ToT mcore & ToT TE #8755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dimapihtar <dpihtar@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
|
jenkins |
ShriyaPalsamudram
previously approved these changes
Apr 2, 2024
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
jenkins |
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
dimapihtar
changed the title
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
2 similar comments
|
jenkins |
|
jenkins |
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
ShriyaPalsamudram
previously approved these changes
Apr 10, 2024
Signed-off-by: dimapihtar <dpihtar@gmail.com>
|
jenkins |
8 tasks
anmolgupt
pushed a commit
to anmolgupt/NeMo
that referenced
this pull request
Apr 11, 2024
* add mcore dataset updates Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix mcore import Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore installation Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore installation Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update apex, TE & PyT Signed-off-by: dimapihtar <dpihtar@gmail.com> * setup pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * add mcore to python path Signed-off-by: dimapihtar <dpihtar@gmail.com> * add mcore to pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * update pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * change pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert mcore ds changes Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * add qk_layernorm support for Falcon self attn submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * code style changes Signed-off-by: dimapihtar <dpihtar@gmail.com> * add nemo implementation for get_gpt_layer_ammo_spec Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * skip Llama2 - INT8 SQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * skip Llama2 - INT8 SQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * comment out NeMo PTQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * bert mcore updates Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add qk_layernorm support for bert's self attention submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * add qk_layernorm support for bert's self attn submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change mcore commit Signed-off-by: dimapihtar <dpihtar@gmail.com> * switch back to mcore original Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfix Signed-off-by: dimapihtar <dpihtar@gmail.com> * update TE Signed-off-by: dimapihtar <dpihtar@gmail.com> * change legacy model to mcore based model for lora Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unnecessary files Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore commit Signed-off-by: dimapihtar <dpihtar@gmail.com> * uncomment PTQ tests Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove sbert Signed-off-by: dimapihtar <dpihtar@gmail.com> * switch back to mcore main Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unused variable Signed-off-by: dimapihtar <dpihtar@gmail.com> * comment out CUDA Graph test Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
ftxj
pushed a commit
to ftxj/NeMo
that referenced
this pull request
Apr 12, 2024
* add mcore dataset updates Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix mcore import Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore installation Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore installation Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update apex, TE & PyT Signed-off-by: dimapihtar <dpihtar@gmail.com> * setup pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * add mcore to python path Signed-off-by: dimapihtar <dpihtar@gmail.com> * add mcore to pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * update pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * change pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert mcore ds changes Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * add qk_layernorm support for Falcon self attn submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * code style changes Signed-off-by: dimapihtar <dpihtar@gmail.com> * add nemo implementation for get_gpt_layer_ammo_spec Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * skip Llama2 - INT8 SQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * skip Llama2 - INT8 SQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * comment out NeMo PTQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * bert mcore updates Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add qk_layernorm support for bert's self attention submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * add qk_layernorm support for bert's self attn submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change mcore commit Signed-off-by: dimapihtar <dpihtar@gmail.com> * switch back to mcore original Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfix Signed-off-by: dimapihtar <dpihtar@gmail.com> * update TE Signed-off-by: dimapihtar <dpihtar@gmail.com> * change legacy model to mcore based model for lora Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unnecessary files Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore commit Signed-off-by: dimapihtar <dpihtar@gmail.com> * uncomment PTQ tests Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove sbert Signed-off-by: dimapihtar <dpihtar@gmail.com> * switch back to mcore main Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unused variable Signed-off-by: dimapihtar <dpihtar@gmail.com> * comment out CUDA Graph test Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: jxin <jxin@nvidia.com>
suiyoubi
pushed a commit
that referenced
this pull request
May 2, 2024
* add mcore dataset updates Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix mcore import Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore installation Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore installation Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update apex, TE & PyT Signed-off-by: dimapihtar <dpihtar@gmail.com> * setup pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * add mcore to python path Signed-off-by: dimapihtar <dpihtar@gmail.com> * add mcore to pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * update pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * change pythonpath for mcore Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore pythonpath Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert mcore ds changes Signed-off-by: dimapihtar <dpihtar@gmail.com> * revert config Signed-off-by: dimapihtar <dpihtar@gmail.com> * add qk_layernorm support for Falcon self attn submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * code style changes Signed-off-by: dimapihtar <dpihtar@gmail.com> * add nemo implementation for get_gpt_layer_ammo_spec Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * skip Llama2 - INT8 SQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * skip Llama2 - INT8 SQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * comment out NeMo PTQ test Signed-off-by: dimapihtar <dpihtar@gmail.com> * bert mcore updates Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add qk_layernorm support for bert's self attention submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * add qk_layernorm support for bert's self attn submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change mcore commit Signed-off-by: dimapihtar <dpihtar@gmail.com> * switch back to mcore original Signed-off-by: dimapihtar <dpihtar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bugfix Signed-off-by: dimapihtar <dpihtar@gmail.com> * update TE Signed-off-by: dimapihtar <dpihtar@gmail.com> * change legacy model to mcore based model for lora Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unnecessary files Signed-off-by: dimapihtar <dpihtar@gmail.com> * update mcore commit Signed-off-by: dimapihtar <dpihtar@gmail.com> * uncomment PTQ tests Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove sbert Signed-off-by: dimapihtar <dpihtar@gmail.com> * switch back to mcore main Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unused variable Signed-off-by: dimapihtar <dpihtar@gmail.com> * comment out CUDA Graph test Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tim Moon <4406448+timmoon10@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com> Signed-off-by: Ao Tang <aot@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information