Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package info #8793

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Update package info #8793

merged 1 commit into from
Apr 13, 2024

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: eharper <eharper@nvidia.com>
@ericharper ericharper merged commit cb22d71 into main Apr 13, 2024
89 of 126 checks passed
@ericharper ericharper deleted the update_package branch April 13, 2024 02:03
hannahli-nv pushed a commit to hannahli-nv/NeMo that referenced this pull request Apr 17, 2024
Signed-off-by: eharper <eharper@nvidia.com>
jbaczek pushed a commit that referenced this pull request Apr 21, 2024
Signed-off-by: eharper <eharper@nvidia.com>
pablo-garay added a commit that referenced this pull request Apr 24, 2024
* update package info (#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
* update package info (#8793)

Signed-off-by: eharper <eharper@nvidia.com>

* update mcore (#8917)

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* Use new mcore transformer block config handling

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* API fixes

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert chages to CI and Dockerfile

Signed-off-by: Jan Baczek <jbaczek@nvidia.com>

---------

Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
alxzhang-amazon pushed a commit to alxzhang-amazon/NeMo that referenced this pull request Apr 26, 2024
Signed-off-by: eharper <eharper@nvidia.com>
suiyoubi pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: eharper <eharper@nvidia.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Signed-off-by: eharper <eharper@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants