Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarr ckpt to torch_dist ckpt converter #8842

Merged
merged 13 commits into from
May 1, 2024
Merged

Conversation

dimapihtar
Copy link
Collaborator

What does this PR do ?

Adds a script to convert zarr ckpt format to torch distributed ckpt format.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar dimapihtar added the feature request/PR for a new feature label Apr 6, 2024
@github-actions github-actions bot added the NLP label Apr 6, 2024
@dimapihtar dimapihtar changed the title Dpykhtar/zarr to torch dist zarr ckpt to torch_dist ckpt converter Apr 6, 2024
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Apr 20, 2024
@dimapihtar dimapihtar marked this pull request as ready for review April 22, 2024 17:35
@dimapihtar
Copy link
Collaborator Author

jenkins

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@github-actions github-actions bot removed the NLP label Apr 30, 2024
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@github-actions github-actions bot added the NLP label Apr 30, 2024
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@github-actions github-actions bot removed the NLP label Apr 30, 2024
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar dimapihtar merged commit 8e65042 into main May 1, 2024
129 checks passed
@dimapihtar dimapihtar deleted the dpykhtar/zarr_to_torch_dist branch May 1, 2024 11:00
suiyoubi pushed a commit that referenced this pull request May 2, 2024
* add zarr to torch_dist ckpt converter

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add zarr to torch_dist ckpt converter

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add bert and gpt-sft support

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* switch to MegatronTrainerBuilder

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove unused imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert config

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* add zarr to torch_dist ckpt converter

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add zarr to torch_dist ckpt converter

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add bert and gpt-sft support

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* switch to MegatronTrainerBuilder

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove unused imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert config

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request/PR for a new feature Run CICD stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants