Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sbert since we have bert_embedding_model #8844

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

JRD971000
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@JRD971000 JRD971000 self-assigned this Apr 6, 2024
@github-actions github-actions bot added the NLP label Apr 6, 2024
@JRD971000
Copy link
Collaborator Author

Jenkins

@JRD971000
Copy link
Collaborator Author

Jenkins

@JRD971000 JRD971000 merged commit b273fa6 into main Apr 9, 2024
13 checks passed
@JRD971000 JRD971000 deleted the alit/remove_redunant_sbert branch April 9, 2024 19:40
rachitgarg91 pushed a commit to rachitgarg91/NeMo that referenced this pull request Apr 10, 2024
Signed-off-by: rachitg <rachitg@nvidia.com>
anmolgupt pushed a commit to anmolgupt/NeMo that referenced this pull request Apr 11, 2024
ftxj pushed a commit to ftxj/NeMo that referenced this pull request Apr 12, 2024
suiyoubi pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: Ao Tang <aot@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants