Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix r2.0.0rc0.beta version to be PEP 440 compliant #8915

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ShriyaPalsamudram
Copy link
Collaborator

@ShriyaPalsamudram ShriyaPalsamudram commented Apr 13, 2024

What does this PR do ?

Change PRE_RELEASE to rc0 to be PEP 440 compliant. The name cannot have both rc and beta in it

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ShriyaPalsamudram
Copy link
Collaborator Author

jenkins

@ShriyaPalsamudram
Copy link
Collaborator Author

jenkins

Signed-off-by: Shriya Palsamudram <spalsamudram@nvidia.com>
@ShriyaPalsamudram
Copy link
Collaborator Author

jenkins

@ShriyaPalsamudram ShriyaPalsamudram merged commit bda7eee into r2.0.0.rc0.beta Apr 15, 2024
11 checks passed
@ShriyaPalsamudram ShriyaPalsamudram deleted the shriya/fix_version branch April 15, 2024 22:22
github-actions bot pushed a commit that referenced this pull request Apr 15, 2024
Signed-off-by: Shriya Palsamudram <spalsamudram@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants