Add safe extraction of nemo tar files #8976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Abhishree <abhishreetm@gmail.com>
athitten
force-pushed
the
athitten/safe_extraction
branch
from
de2d0b6
to
6b34109
Compare
|
jenkins |
ericharper
reviewed
May 1, 2024
| if SaveRestoreConnector._is_safe_path(member, extract_to): | ||
| tar.extract(member, extract_to) | ||
| else: | ||
| print(f"Skipping potentially unsafe member: {member.name}") |
There was a problem hiding this comment.
can you update this to logging ?
Signed-off-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Add safe extraction of nemo tar files Signed-off-by: Abhishree <abhishreetm@gmail.com> * Fix bugs Signed-off-by: Abhishree <abhishreetm@gmail.com> * Replace print with logging Signed-off-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com> --------- Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enables safe extraction of nemo tar files in the SaveRestoreConnector class. To avoid security risks of arbitraty file writes via maliciously crafted paths in the tar file, the safe extraction checks:
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information