Prevent duplicated checkpoints #9015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/prevent-duplicated-checkpoints
branch
from
b92f3bd
to
76df0d4
Compare
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/prevent-duplicated-checkpoints
branch
from
51ad5a2
to
10297aa
Compare
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
8 tasks
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
…DIA/NeMo into mblaz/prevent-duplicated-checkpoints
dimapihtar
approved these changes
May 6, 2024
8 tasks
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jun 5, 2024
* Prevent duplicated checkpoints Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add versioning to save_to Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add versioning logic to all .nemo files Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add versioning test Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add dist-ckpt test Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Rename existing ckpts instead of using different name Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add comment Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Run dist-ckpt test on GPU Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Prevent saving last for non-equal val intervals Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Move checkpoint on rank 0 Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the behavior of encountering an existing distributed checkpoint. Previously the save was skipped based on logic in
NLPDDPStrategy.save_checkpoint, which is not a good place for such logic (strategy should just save the checkpoint). This PR reuses the PTL versioning mechanism to adjust the checkpoint name accordingly (add-v1suffix to ckpt name)Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
There's no need to comment
jenkinson the PR to trigger Jenkins CI.The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information