Handle case where num_query_groups is set to null for LoRA config setup #9075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
vysarge
force-pushed
the
vsarge/lora_num_query_groups
branch
from
4b7c71e
to
6fc4033
Compare
|
@cuichenx / @ericharper, can you review this one? Thanks! |
|
Merging this because it's only failing on a problematic test which is being commented out in #9085 |
suiyoubi
pushed a commit
that referenced
this pull request
May 2, 2024
…up (#9075) Signed-off-by: Valerie Sarge <vsarge@nvidia.com> Signed-off-by: Ao Tang <aot@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…up (NVIDIA#9075) Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Currently, LoRA setup uses either the num_query_groups setting (if set) or the num_attention_heads setting, if not. However, if num_query_groups is set explicitly to null, this line evaluates to None instead of the num_attention_heads value, resulting in
TypeError: unsupported operand type(s) for *: 'int' and 'NoneType'. This tiny change just adds an additional check to account for this situation.Collection: nlp
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
There's no need to comment
jenkinson the PR to trigger Jenkins CI.The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information