Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NeMo-UX] Add data module #9133

Merged
merged 3 commits into from
May 8, 2024
Merged

[NeMo-UX] Add data module #9133

merged 3 commits into from
May 8, 2024

Conversation

cuichenx
Copy link
Collaborator

@cuichenx cuichenx commented May 7, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
nemo/lightning/base.py Dismissed Show dismissed Hide dismissed
tests/lightning/test_data.py Dismissed Show dismissed Hide dismissed
tests/lightning/test_data.py Dismissed Show dismissed Hide dismissed
@cuichenx cuichenx requested a review from marcromeyn May 8, 2024 14:33
@pablo-garay
Copy link
Collaborator

pablo-garay commented May 8, 2024

CI (Nemo_CICD_Test ) passed: https://github.com/NVIDIA/NeMo/actions/runs/8993756408

@pablo-garay pablo-garay merged commit fd009b9 into main May 8, 2024
12 checks passed
@pablo-garay pablo-garay deleted the nemo-ux/datamodule branch May 8, 2024 15:33
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* add datamodules

Signed-off-by: Chen Cui <chcui@nvidia.com>

* add test and fix pretraining

Signed-off-by: Chen Cui <chcui@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* add datamodules

Signed-off-by: Chen Cui <chcui@nvidia.com>

* add test and fix pretraining

Signed-off-by: Chen Cui <chcui@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants