-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand documentation for data parallelism and distributed optimizer #9227
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Hello, I assigned myself as a reviewer. I am the tech writer on the NeMo team and provided a review of #9184. I will make similar copyedits to the content. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes and provided a few edits.
Signed-off-by: Tim Moon <tmoon@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the file and added copyedits and formatting changes. Please review and implement the changes or ask me questions about the suggestions.
Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com>
…VIDIA#9227) * Add distributed optimizer to docs Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug RST table Signed-off-by: Tim Moon <tmoon@nvidia.com> * Review suggestions from @jgerh Signed-off-by: Tim Moon <tmoon@nvidia.com> * Copyedits and formatting changes Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
…9227) * Add distributed optimizer to docs Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug RST table Signed-off-by: Tim Moon <tmoon@nvidia.com> * Review suggestions from @jgerh Signed-off-by: Tim Moon <tmoon@nvidia.com> * Copyedits and formatting changes Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
…VIDIA#9227) * Add distributed optimizer to docs Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug RST table Signed-off-by: Tim Moon <tmoon@nvidia.com> * Review suggestions from @jgerh Signed-off-by: Tim Moon <tmoon@nvidia.com> * Copyedits and formatting changes Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jennifer Gerhold <jgerhold@nvidia.com>
What does this PR do ?
This expands the documentation for data parallelism and the distributed optimizer
@erhoo82 This may also be a good place to add FSDP documentation.
Collection: NLP
Changelog
Usage
n/a
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information