Use get_vocab
method instead of vocab
#9289
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes the issue of missing vocab property for NeMo AutoTokenizer.
Currently, NeMo's AutoTokenizer obtains a list of vocabulary from
tokenizer.vocab
.However, it can be problematic for the following reasons:
For example, non-fast version of T5Tokenizer does not seem to have
vocab
as follows:This can be a problem for
GPTSFTChatDataset
because it assumes that a given tokenizer has avocab
property.NeMo/nemo/collections/nlp/data/language_modeling/megatron/gpt_sft_chat_dataset.py
Line 313 in 7d3d9ac
This PR renames a reference to
vocab
property toget_vocab
method.I believe that this method also returns a list of vocabulary in a same manner as
vocab
property.Thus, existing tokenizers would not be affected.
Collection: [Note which collection this PR will affect]
This PR may affect tokenizer component.
Changelog
renamed
vocab
toget_vocab
Usage
n/a
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
n/a