Call teardown even when something fails. #9331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
tfogal
force-pushed
the
tfogal/teardown-sd
branch
from
16a55a0
to
7f93dff
Compare
github-actions
bot
removed
core
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
Commenting to kill the stale label. This really just needs a reviewer. Would be great to know if this is the desired solution; I think I'm seeing the same thing in another model and would replicate this approach there, if so. |
If something goes wrong in the training, recent PyTorches start warning us: ``` [rank0]:[W528 18:14:19.086678488 ProcessGroupNCCL.cpp:1122] WARNING: process group has NOT been destroyed before it is being destructed. On normal program exit, the application should call destroy_process_group to ensure that any pending NCCL data transfers have finished in this process. In rare cases this process can exit before this point and block the progress of another member of the process group. This constraint has always been present, but this warning has only been added since PyTorch 2.4 ``` With the finally clause, we're guaranteed to always properly finish up our instances and thus this avoids the issue. Signed-off-by: Tom Fogal <60981+tfogal@users.noreply.github.com>
tfogal
force-pushed
the
tfogal/teardown-sd
branch
from
a7565e5
to
441a650
Compare
Signed-off-by: tfogal <tfogal@users.noreply.github.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Avoid tons of terminal spam such as:
when an error occurs, which can obscure the real error.
Collection: Stable diffusion
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.