Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPU rank specifiers for EP & DDP #9362

Closed
wants to merge 4 commits into from

Conversation

akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Jun 3, 2024

What does this PR do ?

I introduced in mcore a config logger, which when enabled dumps to disk configuration options at entry points of mcore. The logger uses the rank as part of the logs filepath & as a result we need a way to specify these when the distributed environment has not yet been setup.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jun 3, 2024
@akoumpa akoumpa force-pushed the akoumparouli/mcore_tokenizer_signature_pairing branch from 2cac42e to 4bf4928 Compare June 3, 2024 17:10
@akoumpa akoumpa force-pushed the akoumparouli/mcore_tokenizer_signature_pairing branch 2 times, most recently from 96f1863 to bf3667d Compare June 5, 2024 05:08
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/mcore_tokenizer_signature_pairing branch from 1a8b26f to bb957ec Compare June 7, 2024 19:39
@akoumpa akoumpa changed the title Akoumparouli/mcore tokenizer signature pairing mcore/nemo tokenizer signature pairing Jun 7, 2024
@akoumpa akoumpa marked this pull request as ready for review June 7, 2024 19:40
@akoumpa akoumpa self-assigned this Jun 7, 2024
@akoumpa akoumpa added Run CICD and removed Run CICD labels Jun 7, 2024
akoumpa and others added 2 commits June 11, 2024 18:00
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/mcore_tokenizer_signature_pairing branch 2 times, most recently from 1fbbe4a to a97fbdd Compare June 12, 2024 02:38
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/mcore_tokenizer_signature_pairing branch from d708913 to 9691c3d Compare June 12, 2024 02:39
@akoumpa akoumpa changed the title mcore/nemo tokenizer signature pairing Add MPU rank specifiers for EP & DDP Jun 12, 2024
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant