Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(notifications): Fix extraction of last 2K chars #9450

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jun 12, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Jun 12, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

ci(notifications): Fix extract of last 2K chars

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/enrich-notification branch from 7078372 to ae6e493 Compare June 12, 2024 08:46
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/enrich-notification branch from 20468aa to d2405c4 Compare June 12, 2024 08:54
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 12, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/enrich-notification branch from d2405c4 to 363c8c1 Compare June 12, 2024 09:00
@ko3n1g ko3n1g changed the title Ko3n1g/ci/enrich notification ci(notifications): Fix extraction of last 2K chars Jun 12, 2024
@ko3n1g ko3n1g marked this pull request as ready for review June 12, 2024 09:01
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 12, 2024
@ko3n1g ko3n1g merged commit 1c0bef0 into main Jun 12, 2024
111 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/enrich-notification branch June 12, 2024 16:36
galv pushed a commit to galv/NeMo that referenced this pull request Jun 13, 2024
ci(notifications): Fix extract of last 2K chars

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
ci(notifications): Fix extract of last 2K chars

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
ci(notifications): Fix extract of last 2K chars

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants