Use ModelOpt build_tensorrt_llm for building engines for qnemo checkpoints #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
This reverts commit b0a4dd3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
This reverts commit 9e419e3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
This reverts commit be70812. Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
…gnment Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
galv
pushed a commit
to galv/NeMo
that referenced
this pull request
Jun 13, 2024
…oints (NVIDIA#9452) * Enable specyfing alpha for SQ Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Enable specifying use_custom_all_reduce for export Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use native TRT-LLM param names in export (partial) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Detect TRT-LLM checkpoint programatically Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pass use_custom_all_reduce in test_nemo_export.py Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Paramter parsing bugfix Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Paramter parsing bugfix" This reverts commit b0a4dd3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Enable specifying use_custom_all_reduce for export" This reverts commit 9e419e3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Pass use_custom_all_reduce in test_nemo_export.py" This reverts commit be70812. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Rename checkpoint detection function Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use ModelOpt build_tensorrt_llm utility for qnemo for performance alignment Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Import fix Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com>
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
…oints (NVIDIA#9452) * Enable specyfing alpha for SQ Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Enable specifying use_custom_all_reduce for export Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use native TRT-LLM param names in export (partial) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Detect TRT-LLM checkpoint programatically Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pass use_custom_all_reduce in test_nemo_export.py Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Paramter parsing bugfix Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Paramter parsing bugfix" This reverts commit b0a4dd3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Enable specifying use_custom_all_reduce for export" This reverts commit 9e419e3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Pass use_custom_all_reduce in test_nemo_export.py" This reverts commit be70812. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Rename checkpoint detection function Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use ModelOpt build_tensorrt_llm utility for qnemo for performance alignment Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Import fix Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…oints (NVIDIA#9452) * Enable specyfing alpha for SQ Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Enable specifying use_custom_all_reduce for export Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use native TRT-LLM param names in export (partial) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Detect TRT-LLM checkpoint programatically Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pass use_custom_all_reduce in test_nemo_export.py Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Paramter parsing bugfix Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Paramter parsing bugfix" This reverts commit b0a4dd3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Enable specifying use_custom_all_reduce for export" This reverts commit 9e419e3. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "Pass use_custom_all_reduce in test_nemo_export.py" This reverts commit be70812. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Rename checkpoint detection function Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use ModelOpt build_tensorrt_llm utility for qnemo for performance alignment Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Import fix Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Use ModelOpt's
build_tensorrt_llmutility for accuracy and performance alignment for engines build.This introduces modelopt as an extra dependency in
nemo.exportmodule and it is a temporal solution. In long term engines for qnemo should be built directly using tensorrt_llm.Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information