Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resiliency features update #9714

Open
wants to merge 17 commits into
base: r2.0.0rc1
Choose a base branch
from
Open

Conversation

jbieniusiewi
Copy link
Collaborator

@jbieniusiewi jbieniusiewi commented Jul 12, 2024

What does this PR do ?

Changes for the updated version of resiliency features:

  • Fault Tolerance
  • Straggler Detection

Collection: [Note which collection this PR will affect]

Changelog

  • Updated/clarified documentation
  • Removed duplicated "straggler detection" section from the documentation
  • Updated straggler detection unit test
  • Do not pass logger instance to the straggler det. callback
  • Exposed safety_factor FT param
  • Pass exp_dir to the FT callback

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
…s per data loader

Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
@github-actions github-actions bot added the core Changes to NeMo Core label Jul 12, 2024
jbieniusiewi and others added 13 commits July 12, 2024 13:09
Signed-off-by: jbieniusiewi <jbieniusiewi@users.noreply.github.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
Signed-off-by: jbieniusiewi <jbieniusiewi@users.noreply.github.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
Signed-off-by: jbieniusiewi <jbieniusiewi@users.noreply.github.com>
Signed-off-by: Jacek Bieniusiewicz <jbieniusiewi@nvidia.com>
@jbieniusiewi jbieniusiewi marked this pull request as ready for review July 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant