fix arg name #9848
Merged
fix arg name #9848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sangkug Lym <slym@nvidia.com>
ericharper
reviewed
Jul 23, 2024
| @@ -257,7 +257,7 @@ def __init__( | |||
|
|
|||
| te_version = packaging.version.Version(version("transformer-engine")) | |||
| if te_version >= packaging.version.Version("1.5.0dev") and ( | |||
| not self.input_is_parallel and model_parallel_config.tp_comm_disable_qkv | |||
| not self.input_is_parallel and model_parallel_config.tp_comm_overlap_disable_qkv | |||
There was a problem hiding this comment.
is it possible someone is using the old arg name in their config?
There was a problem hiding this comment.
I checked and the only place this arg is supposed to be used is MCORE.
However, we haven't merged the code lines that use this arg yet. So, I think it is totally fine.
There was a problem hiding this comment.
Should we set a default? Won't someone using an older version of mcore error here?
There was a problem hiding this comment.
can we do a getattr to be on the safe side?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nemo/collections/nlp/modules/common/megatron/adapters/parallel_adapters.py
Fixed
Show fixed
Hide fixed
akoumpa
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix arg name typo
Changelog
tp_comm_disable_qkvtotp_comm_overlap_disable_qkvUsage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information