Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Knob for OnlineSampling by introducing 'global_sample_mapping' in the SFT config.yaml #9913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

conver334
Copy link

What does this PR do ?

Adds a Knob for OnlineSampling by introducing a new parameter 'global_sample_mapping' in the SFT config YAML(default value is false).
The feature was proposed in this Nvbug. This will allow users to choose the data sample method that best suits their needs.

Collection: NeMo's NLP collection

Changelog

  • SFT config.yaml
  • Passing parameters
  • Control whether to use OnlineSampleMapping

Usage

change 'global_sample_mapping' in megatron_gpt_finetuning_config.yaml
False (default): Use OnlineSampleMapping. Shuffle the dataset within each epoch.
True: Shuffle the replicated data all together.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

@ericharper
Anyone in the community is free to review the PR once the checks have passed.

Additional Information

  • Related to nvbug
    The second suggested Improvement has not been fixed yet

…ping.

Signed-off-by: conver334 <conver334@gmail.com>
@github-actions github-actions bot added the NLP label Jul 26, 2024
@akoumpa akoumpa self-requested a review July 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants