Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QBSP support (for extended limits) #133

Merged
merged 2 commits into from
Aug 23, 2021
Merged

QBSP support (for extended limits) #133

merged 2 commits into from
Aug 23, 2021

Conversation

Paril
Copy link
Contributor

@Paril Paril commented Aug 19, 2021

This needs testing, and some back&forth with qbism (see qbism/q2tools-220#11) who has been implementing an "extended limits" format similar to BSP2 into their compiler.

I did test the load in q2pro itself, and it seemed to work, although obviously network limitations need to be addressed separately and that's not in the scope of this push since that requires breaking compatibility.

@motorsep
Copy link

Tried compiling this code using Paril's Q2RTX forks https://github.com/Paril/Q2RTX/tree/extended_limits (which is the same thing basically)
I enabled extended limits and qbsp code by adding #define EXTENDED_LIMITS to #if USE_CLIENT block in inc/shared/config.h, but I get this error:

13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>bloom.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>bsp_mesh.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>freecam.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>material.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>matrix.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>Generating Code...
13>Compiling...
13>mgpu.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>path_tracer.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>physical_sky.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>precomputed_sky.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>profiler.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>shadow_map.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>textures.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>tone_mapping.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>transparency.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>uniform_buffer.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>vertex_buffer.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>vk_util.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>buddy_allocator.c
13>device_memory_allocator.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>god_rays.c
13>F:\Games\Q2RTX\src\refresh\vkpt\shader/global_ubo.h(241,1): fatal error C1189: #error: need to update constant here
13>conversion.c
13>Generating Code...
13>Done building project "client.vcxproj" -- FAILED.

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants